Bug 1844665 - rename RPMSetBoolPref so it's more obvious you can use it for int/char prefs, r=jhirsch

Differential Revision: https://phabricator.services.mozilla.com/D184742

browser/components/protections/content/protections.mjs

@@ -390,7 +390,7 @@ document.addEventListener("DOMContentLoaded", e => {
   let exitIcon = document.querySelector("#mobile-hanger .exit-icon");
   // hide the mobile promotion and keep hidden with a pref.
   exitIcon.addEventListener("click", () => {
-    RPMSetBoolPref("browser.contentblocking.report.show_mobile_app", false);
+    RPMSetPref("browser.contentblocking.report.show_mobile_app", false);
     document.getElementById("mobile-hanger").classList.add("hidden");
   });
 

browser/components/protections/content/vpn-card.mjs

@@ -74,7 +74,7 @@ export default class VPNCard {
           );
 
           // hide the promo banner if the user is already subscribed to vpn
-          await RPMSetBoolPref(
+          await RPMSetPref(
             "browser.contentblocking.report.hide_vpn_banner",
             true
           );
@@ -98,6 +98,6 @@ export default class VPNCard {
     vpnBanner.classList.remove("hidden");
     this.doc.sendTelemetryEvent("show", "vpn_banner");
     // VPN banner only shows on the first visit, flip a pref so it does not show again.
-    RPMSetBoolPref("browser.contentblocking.report.hide_vpn_banner", true);
+    RPMSetPref("browser.contentblocking.report.hide_vpn_banner", true);
   }
 }

toolkit/actors/RemotePageChild.sys.mjs

@@ -33,7 +33,7 @@ export class RemotePageChild extends JSWindowActorChild {
       "RPMGetIntPref",
       "RPMGetStringPref",
       "RPMGetBoolPref",
-      "RPMSetBoolPref",
+      "RPMSetPref",
       "RPMGetFormatURLPref",
       "RPMIsWindowPrivate",
     ];
@@ -205,7 +205,7 @@ export class RemotePageChild extends JSWindowActorChild {
     return Services.prefs.getBoolPref(aPref);
   }
 
-  RPMSetBoolPref(aPref, aVal) {
+  RPMSetPref(aPref, aVal) {
     return this.wrapPromise(lazy.AsyncPrefs.set(aPref, aVal));
   }
 

toolkit/content/aboutNetError.mjs

@@ -634,7 +634,7 @@ function showNativeFallbackWarning() {
     "nativeFallbackIgnoreButton"
   );
   nativeFallbackIgnoreButton.addEventListener("click", () => {
-    RPMSetBoolPref("network.trr.display_fallback_warning", false);
+    RPMSetPref("network.trr.display_fallback_warning", false);
     retryThis(nativeFallbackIgnoreButton);
   });
 
@@ -876,7 +876,7 @@ function setupBlockingReportingUI() {
   checkbox.checked = !!reportingAutomatic;
 
   checkbox.addEventListener("change", function ({ target: { checked } }) {
-    RPMSetBoolPref("security.xfocsp.errorReporting.automatic", checked);
+    RPMSetPref("security.xfocsp.errorReporting.automatic", checked);
 
     // If we're enabling reports, send a report for this failure.
     if (checked) {

toolkit/modules/RemotePageAccessManager.sys.mjs

@@ -101,7 +101,7 @@ export let RemotePageAccessManager = {
         "security.xfocsp.errorReporting.enabled",
         "network.trr.display_fallback_warning",
       ],
-      RPMSetBoolPref: [
+      RPMSetPref: [
         "security.xfocsp.errorReporting.automatic",
         "network.trr.display_fallback_warning",
       ],
@@ -190,7 +190,7 @@ export let RemotePageAccessManager = {
       ],
       RPMAddMessageListener: ["*"],
       RPMRemoveMessageListener: ["*"],
-      RPMSetBoolPref: [
+      RPMSetPref: [
         "browser.contentblocking.report.show_mobile_app",
         "browser.contentblocking.report.hide_vpn_banner",
       ],

tools/lint/eslint/eslint-plugin-mozilla/lib/environments/remote-page.js

@@ -18,7 +18,7 @@ module.exports = {
     RPMGetIntPref: false,
     RPMGetStringPref: false,
     RPMGetBoolPref: false,
-    RPMSetBoolPref: false,
+    RPMSetPref: false,
     RPMGetFormatURLPref: false,
     RPMIsTRROnlyFailure: false,
     RPMIsFirefox: false,