From 165b6e2e2626bf2400aebf5bd6bbc0e4c62ef004 Mon Sep 17 00:00:00 2001
From: James Teh <jteh@mozilla.com>
Date: Tue, 22 Jun 2021 23:11:25 +0000
Subject: [PATCH] Bug 1598750: Make browser_nested_iframe.js wait for doc load
 complete if the nested iframe doc accessible isn't present yet. r=morgan

For OOP iframes, a doc load complete event on the embedder document doesn't necessarily mean the iframe document has finished loading yet.
We already checked for the busy state on the nested iframe doc and waited for a doc load complete event in that case.
However, depending on timing, it might be possible there is no document at all (even a busy one), so we should wait for doc load complete in that case too.
This is a speculative fix; I wasn't able to reproduce this myself.

Differential Revision: https://phabricator.services.mozilla.com/D118123
---
 .../browser/fission/browser_nested_iframe.js  | 24 +++++++++++++------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/accessible/tests/browser/fission/browser_nested_iframe.js b/accessible/tests/browser/fission/browser_nested_iframe.js
index 0e48d767f888..a9cc236ee19a 100644
--- a/accessible/tests/browser/fission/browser_nested_iframe.js
+++ b/accessible/tests/browser/fission/browser_nested_iframe.js
@@ -38,17 +38,27 @@ function getOsPid(browsingContext) {
 addAccessibleTask(
   `<iframe id="${NESTED_IFRAME_ID}" src="${nestedURL.href}"/>`,
   async function(browser, iframeDocAcc, contentDocAcc) {
+    ok(iframeDocAcc, "IFRAME document accessible is present");
     let nestedDocAcc = findAccessibleChildByID(
       iframeDocAcc,
       NESTED_IFRAME_DOC_BODY_ID
     );
-
-    ok(iframeDocAcc, "IFRAME document accessible is present");
-    ok(nestedDocAcc, "Nested IFRAME document accessible is present");
-
-    const state = {};
-    nestedDocAcc.getState(state, {});
-    if (state.value & STATE_BUSY) {
+    let waitForNestedDocLoad = false;
+    if (nestedDocAcc) {
+      const state = {};
+      nestedDocAcc.getState(state, {});
+      if (state.value & STATE_BUSY) {
+        info("Nested IFRAME document accessible is present but busy");
+        waitForNestedDocLoad = true;
+      } else {
+        ok(true, "Nested IFRAME document accessible is present and ready");
+      }
+    } else {
+      info("Nested IFRAME document accessible is not present yet");
+      waitForNestedDocLoad = true;
+    }
+    if (waitForNestedDocLoad) {
+      info("Waiting for doc load complete on nested iframe document");
       nestedDocAcc = (
         await waitForEvent(
           EVENT_DOCUMENT_LOAD_COMPLETE,