Bug 1591874 - Move VariablesView files to devtools/client/storage. r=miker.

Since the storage inspector is the last consumer of the VariablesView,
it makes sense to move the component directly in the storage inspector
folder.
Since it can't have a controller, the bits where we were checking this
are removed.

Differential Revision: https://phabricator.services.mozilla.com/D54734

--HG--
extra : moz-landing-system : lando

devtools/.eslintrc.js

@@ -32,6 +32,7 @@ module.exports = {
       "client/framework/**",
       "client/shared/*.jsm",
       "client/shared/widgets/*.jsm",
+      "client/storage/VariablesView.jsm",
     ],
     "rules": {
       "consistent-return": "off",
@@ -64,6 +65,8 @@ module.exports = {
     "files": [
       "client/framework/**",
       "client/shared/widgets/*.jsm",
+      "client/storage/VariablesView.jsm",
+      "client/storage/VariablesView.jsm",
     ],
     "rules": {
       "no-shadow": "off",

devtools/client/shared/test/unit/test_VariablesView_filtering-without-controller.js

@@ -6,7 +6,7 @@
 // Test that VariablesView._doSearch() works even without an attached
 // VariablesViewController (bug 1196341).
 const { VariablesView } = ChromeUtils.import(
-  "resource://devtools/client/shared/widgets/VariablesView.jsm"
+  "resource://devtools/client/storage/VariablesView.jsm"
 );
 const { require } = ChromeUtils.import("resource://devtools/shared/Loader.jsm");
 const { globals } = require("devtools/shared/builtin-modules");

devtools/client/shared/test/unit/test_VariablesView_getString_promise.js

@@ -4,7 +4,7 @@
 "use strict";
 
 const { VariablesView } = ChromeUtils.import(
-  "resource://devtools/client/shared/widgets/VariablesView.jsm"
+  "resource://devtools/client/storage/VariablesView.jsm"
 );
 
 const PENDING = {

devtools/client/storage/moz.build

@@ -8,7 +8,8 @@ BROWSER_CHROME_MANIFESTS += ['test/browser.ini']
 
 DevToolsModules(
     'panel.js',
-    'ui.js'
+    'ui.js',
+    'VariablesView.jsm',
 )
 
 with Files('**'):

devtools/client/storage/ui.js

@@ -32,7 +32,7 @@ loader.lazyRequireGetter(
 loader.lazyImporter(
   this,
   "VariablesView",
-  "resource://devtools/client/shared/widgets/VariablesView.jsm"
+  "resource://devtools/client/storage/VariablesView.jsm"
 );
 
 /**

devtools/server/actors/webconsole/utils.js

@@ -13,7 +13,7 @@ if (!isWorker) {
   loader.lazyImporter(
     this,
     "VariablesView",
-    "resource://devtools/client/shared/widgets/VariablesView.jsm"
+    "resource://devtools/client/storage/VariablesView.jsm"
   );
   loader.lazyRequireGetter(
     this,