mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1623174 - Do not skip BR followed by a block r=masayuki,emilio 

Differential Revision: https://phabricator.services.mozilla.com/D67298

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Kagami Sascha Rosylight 2020-03-19 19:08:43 +00:00
Родитель 81d1725ad6
Коммит 18b1e19f6c
2 изменённых файлов: 70 добавлений и 1 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

2
layout/generic/nsFrame.cpp
Просмотреть файл

@ -9240,7 +9240,7 @@ nsresult nsIFrame::GetFrameFromDirection(
bool canSkipBr = false;
for (nsIFrame* current = traversedFrame->GetPrevSibling(); current;
current = current->GetPrevSibling()) {
if (IsSelectable(current)) {
if (!current->IsBlockOutside() && IsSelectable(current)) {
canSkipBr = true;
break;
}

69
testing/web-platform/tests/editing/run/caretnavigation.html Normal file
Просмотреть файл

@ -0,0 +1,69 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Caret navigation</title>
<link rel="stylesheet" href="../support/reset.css">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<script>
const KEY_CODE_MAP = {
'ArrowLeft': '\uE012',
'ArrowUp': '\uE013',
'ArrowRight': '\uE014',
'ArrowDown': '\uE015',
};
/**
* Send key event to the target element using test driver. Supports human
* friendly key names for common keyboard scroll operations e.g., arrow keys,
* page keys, etc.
* @param {Node} target
* @param {string} key
* @returns {Promise}
*/
function keyPress(target, key) {
const code = KEY_CODE_MAP[key];
let actions = new test_driver.Actions()
.keyDown(code)
.keyUp(code);
return actions.send();
}
</script>
<div id="container">
<div contenteditable data-title="Move with ArrowLeft to BR following a div">
<div>line 1</div>
<br>
<div class="caret">line 2</div>
</div>
<div contenteditable data-title="Move with ArrowLeft to BR following an img">
<img style="display:block;width:100px;height:100px">
<br>
<div class="caret">line 2</div>
</div>
</div>
<script>
const container = document.getElementById("container");
for (const test of container.children) {
promise_test(async t => {
test.focus();
getSelection().collapse(test.querySelector(".caret"));
await keyPress(test, "ArrowLeft");
const range = getSelection().getRangeAt(0);
assert_equals(range.commonAncestorContainer.localName, "div");
assert_equals(range.startOffset, 3);
assert_equals(range.commonAncestorContainer.childNodes[range.startOffset].localName, "br");
}, test.dataset.title);
}
</script>