Bug 1547103 - Simplify android xpcshell minidump handling; r=jmaher

setupMinidumpDir is no longer called from anywhere.
The check for a crash directory makes sense for browser tests, but not
for xpcshell: in xpcshell, crash reporter does not create the directory --
the harness does.

Differential Revision: https://phabricator.services.mozilla.com/D28902

--HG--
extra : moz-landing-system : lando

testing/xpcshell/remotexpcshelltests.py

@@ -175,14 +175,6 @@ class RemoteXPCShellTestThread(xpcshell.XPCShellTestThread):
                         dump_directory,
                         symbols_path,
                         test_name=None):
-        if not self.device.is_dir(self.remoteMinidumpDir, root=True):
-            # The minidumps directory is automatically created when Fennec
-            # (first) starts, so its lack of presence is a hint that
-            # something went wrong.
-            print("Automation Error: No crash directory (%s) found on remote device" %
-                  self.remoteMinidumpDir)
-            # Whilst no crash was found, the run should still display as a failure
-            return True
         with mozfile.TemporaryDirectory() as dumpDir:
             self.device.pull(self.remoteMinidumpDir, dumpDir)
             crashed = xpcshell.XPCShellTestThread.checkForCrashes(
@@ -512,9 +504,6 @@ class XPCShellRemote(xpcshell.XPCShellTests, object):
         self.device.push(self.xpcDir, self.remoteScriptsDir, timeout=600)
         self.device.chmod(self.remoteScriptsDir, recursive=True, root=True)
 
-    def setupMinidumpDir(self):
-        self.initDir(self.remoteMinidumpDir)
-
     def buildTestList(self, test_tags=None, test_paths=None, verify=False):
         xpcshell.XPCShellTests.buildTestList(
             self, test_tags=test_tags, test_paths=test_paths, verify=verify)