Bug 1209967 - review: Set menu buttons visible in xml & remove dynamic visibility. r=me

--HG--
extra : commitid : Adr5XQoRyOj
extra : rebase_source : 8bbc8b9426fa10c0f71f8240761d39f7c1bea739

mobile/android/base/resources/layout-large-v11/browser_toolbar.xml

@@ -124,8 +124,7 @@
             android:layout_toLeftOf="@id/menu_margin"
             android:layout_alignWithParentIfMissing="true"
             android:contentDescription="@string/menu"
-            android:background="@drawable/browser_toolbar_action_bar_button"
-            android:visibility="gone">
+            android:background="@drawable/browser_toolbar_action_bar_button">
 
         <org.mozilla.gecko.widget.themed.ThemedImageView
                 android:id="@+id/menu_icon"

mobile/android/base/resources/layout/browser_toolbar.xml

@@ -41,8 +41,7 @@
             style="@style/UrlBar.ImageButton"
             android:layout_alignParentRight="true"
             android:contentDescription="@string/menu"
-            android:background="@drawable/shaped_button"
-            android:visibility="gone">
+            android:background="@drawable/shaped_button">
 
         <org.mozilla.gecko.widget.themed.ThemedImageView
                 android:id="@+id/menu_icon"

mobile/android/base/resources/layout/tabs_panel_default.xml

@@ -53,8 +53,7 @@
                          style="@style/UrlBar.ImageButton"
                          android:layout_width="@dimen/tabs_panel_button_width"
                          android:background="@drawable/action_bar_button_inverse"
-                         android:contentDescription="@string/menu"
-                         android:visibility="gone">
+                         android:contentDescription="@string/menu">
 
                 <ImageButton
                         style="@style/UrlBar.ImageButton"

mobile/android/base/tabs/TabsPanel.java

@@ -367,7 +367,6 @@ public class TabsPanel extends LinearLayout
 
         mAddTab.setVisibility(View.VISIBLE);
 
-        mMenuButton.setVisibility(View.VISIBLE);
         mMenuButton.setEnabled(true);
         mPopupMenu.setAnchor(mMenuButton);
     }

mobile/android/base/toolbar/BrowserToolbar.java

@@ -319,7 +319,6 @@ public abstract class BrowserToolbar extends ThemedRelativeLayout
         });
         tabsButton.setImageLevel(0);
 
-        menuButton.setVisibility(View.VISIBLE);
         menuButton.setOnClickListener(new Button.OnClickListener() {
             @Override
             public void onClick(View view) {