Bug 1851452 - Make ESLint rule react-hooks/exhaustive-deps to be an error rather than a warning. r=mossop

Differential Revision: https://phabricator.services.mozilla.com/D187370

.eslintrc.js

@@ -604,6 +604,11 @@ module.exports = {
         "browser/components/pocket/**",
         "devtools/**",
       ],
+      rules: {
+        // react-hooks/recommended has exhaustive-deps as a warning, we prefer
+        // errors, so that raised issues get addressed one way or the other.
+        "react-hooks/exhaustive-deps": "error",
+      },
     },
     {
       // Exempt files with these paths since they have to use http for full coverage