Bug 1505311 - Stop overriding --toolbarbutton-icon-fill-opacity for Dark and Light themes. r=ntim

Differential Revision: https://phabricator.services.mozilla.com/D11151

--HG--
extra : moz-landing-system : lando

browser/components/nsBrowserGlue.js

@@ -1027,7 +1027,8 @@ BrowserGlue.prototype = {
       name: gBrowserBundle.GetStringFromName("lightTheme.name"),
       description: gBrowserBundle.GetStringFromName("lightTheme.description"),
       iconURL: "resource:///chrome/browser/content/browser/defaultthemes/light.icon.svg",
-      textcolor: "#18191a",
+      textcolor: "rgb(24, 25, 26)",
+      icon_color: "rgb(24, 25, 26, 0.7)",
       accentcolor: "#E3E4E6",
       popup: "#fff",
       popup_text: "#0c0c0d",
@@ -1045,6 +1046,7 @@ BrowserGlue.prototype = {
       description: gBrowserBundle.GetStringFromName("darkTheme.description"),
       iconURL: "resource:///chrome/browser/content/browser/defaultthemes/dark.icon.svg",
       textcolor: "rgb(249, 249, 250)",
+      icon_color: "rgb(249, 249, 250, 0.7)",
       accentcolor: "hsl(240, 5%, 5%)",
       popup: "#4a4a4f",
       popup_text: "rgb(249, 249, 250)",

browser/themes/shared/compacttheme.inc.css

@@ -10,8 +10,6 @@
   --toolbar-non-lwt-bgcolor: var(--toolbar-bgcolor);
   --toolbar-non-lwt-textcolor: var(--lwt-text-color);
   --toolbar-non-lwt-bgimage: none;
-
-  --toolbarbutton-icon-fill-opacity: .7;
 }
 
 :root:-moz-lwtheme-brighttext {