Bug 1212624 - Make WeakMapBase be a LinkedListElement, r=Waldo

--HG--
extra : rebase_source : be69b304477e4eb9bca91040076dd3f28cceb055

config/check_utils.py

@@ -7,13 +7,14 @@ import subprocess
 
 def get_all_toplevel_filenames():
     '''Get a list of all the files in the (Mercurial or Git) repository.'''
+    failed_cmds = []
     try:
         cmd = ['hg', 'manifest', '-q']
         all_filenames = subprocess.check_output(cmd, universal_newlines=True,
                                                 stderr=subprocess.PIPE).split('\n')
         return all_filenames
     except:
-        pass
+        failed_cmds.append(cmd)
 
     try:
         # Get the relative path to the top-level directory.
@@ -25,6 +26,6 @@ def get_all_toplevel_filenames():
                                                 stderr=subprocess.PIPE).split('\n')
         return all_filenames
     except:
-        pass
+        failed_cmds.append(cmd)
 
-    raise Exception('failed to run any of the repo manifest commands', cmds)
+    raise Exception('failed to run any of the repo manifest commands', failed_cmds)

js/src/jsweakmap.cpp

@@ -119,8 +119,9 @@ WeakMapBase::sweepZone(JS::Zone* zone)
     }
 
 #ifdef DEBUG
-    for (WeakMapBase* m : zone->gcWeakMapList)
+    for (WeakMapBase* m : zone->gcWeakMapList) {
         MOZ_ASSERT(m->isInList() && m->marked);
+    }
 #endif
 }