Bug 1582057 - Whitelist exceptions from canceled operations in debugger tests, r=jlast.

Differential Revision: https://phabricator.services.mozilla.com/D46345

--HG--
extra : moz-landing-system : lando

devtools/client/debugger/test/mochitest/browser_dbg-chrome-create.js

@@ -7,9 +7,6 @@
 
 // There are shutdown issues for which multiple rejections are left uncaught.
 // See bug 1018184 for resolving these issues.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
 PromiseTestUtils.whitelistRejectionsGlobally(/File closed/);
 PromiseTestUtils.whitelistRejectionsGlobally(/NS_ERROR_FAILURE/);
 

devtools/client/debugger/test/mochitest/browser_dbg-editor-gutter.js

@@ -7,9 +7,6 @@
 
 // FIXME bug 1524374 removing breakpoints in this test can cause uncaught
 // rejections and make bug 1512742 permafail.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
 PromiseTestUtils.whitelistRejectionsGlobally(/NS_ERROR_NOT_INITIALIZED/);
 
 // Utilities for interacting with the editor

devtools/client/debugger/test/mochitest/browser_dbg-inline-cache.js

@@ -10,12 +10,6 @@
  *   - Reload inside debugger with toolbox caching enabled
  */
 
-// Debugger operations may still be in progress when we navigate.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
-PromiseTestUtils.whitelistRejectionsGlobally(/Page has navigated/);
-
 const server = createTestHTTPServer();
 
 let docValue = 1;

devtools/client/debugger/test/mochitest/browser_dbg-inline-script-offset.js

@@ -6,12 +6,6 @@
 
 // Test that breakpoints work when set in inline scripts that do not start at column 0.
 
-// Debugger operations may still be in progress when we navigate.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
-PromiseTestUtils.whitelistRejectionsGlobally(/Page has navigated/);
-
 add_task(async function() {
   const dbg = await initDebugger("doc-inline-script-offset.html");
   await addBreakpoint(dbg, "doc-inline-script-offset.html", 6, 66);

devtools/client/debugger/test/mochitest/browser_dbg-remember-expanded-scopes.js

@@ -3,9 +3,6 @@
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
 // Ignore strange errors when shutting down.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
 PromiseTestUtils.whitelistRejectionsGlobally(/No such actor/);
 PromiseTestUtils.whitelistRejectionsGlobally(/connection just closed/);
 

devtools/client/debugger/test/mochitest/browser_dbg-stepping.js

@@ -5,12 +5,6 @@
 // This test can be really slow on debug platforms
 requestLongerTimeout(5);
 
-// Debugger operations may still be in progress when we step.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
-PromiseTestUtils.whitelistRejectionsGlobally(/Current thread has paused or resumed/);
-
 add_task(async function test() {
   const dbg = await initDebugger("big-sourcemap.html", "big-sourcemap");
   invokeInTab("hitDebugStatement");

devtools/client/debugger/test/mochitest/browser_dbg-tabs.js

@@ -3,12 +3,6 @@
 
 // Tests adding and removing tabs
 
-// Debugger operations may still be in progress when we navigate.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
-PromiseTestUtils.whitelistRejectionsGlobally(/Page has navigated/);
-
 add_task(async function() {
   const dbg = await initDebugger("doc-scripts.html", "simple1", "simple2");
 

devtools/client/debugger/test/mochitest/browser_dbg-windowless-workers.js

@@ -2,15 +2,6 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-// Debugger operations may still be in progress when we switch threads.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
-PromiseTestUtils.whitelistRejectionsGlobally(
-  /Current thread has paused or resumed/
-);
-PromiseTestUtils.whitelistRejectionsGlobally(/Current thread has changed/);
-
 function assertClass(dbg, selector, className, ...args) {
   ok(
     findElement(dbg, selector, ...args).classList.contains(className),

devtools/client/debugger/test/mochitest/browser_dbg-worker-scopes.js

@@ -5,9 +5,6 @@
 // This error shows up sometimes when running the test, and while this is a
 // strange problem that shouldn't be happening it doesn't prevent the test from
 // completing successfully.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
 PromiseTestUtils.whitelistRejectionsGlobally(/Current state is running/);
 
 function findNode(dbg, text) {

devtools/client/debugger/test/mochitest/helpers.js

@@ -1832,3 +1832,16 @@ function evaluateExpressionInConsole(hud, expression) {
 function waitForInspectorPanelChange(dbg) {
   return dbg.toolbox.getPanelWhenReady("inspector");
 }
+
+const { PromiseTestUtils } = ChromeUtils.import(
+  "resource://testing-common/PromiseTestUtils.jsm"
+);
+
+// Debugger operations that are canceled because they were rendered obsolete by
+// a navigation or pause/resume end up as uncaught rejections. These never
+// indicate errors and are whitelisted in all debugger tests.
+PromiseTestUtils.whitelistRejectionsGlobally(/Page has navigated/);
+PromiseTestUtils.whitelistRejectionsGlobally(/Current thread has changed/);
+PromiseTestUtils.whitelistRejectionsGlobally(
+  /Current thread has paused or resumed/
+);

devtools/client/shared/test/browser_dbg_worker-console-04.js

@@ -19,9 +19,6 @@ Services.scriptloader.loadSubScript(
 
 // There are shutdown issues for which multiple rejections are left uncaught.
 // See bug 1018184 for resolving these issues.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
 PromiseTestUtils.whitelistRejectionsGlobally(/connection just closed/);
 
 const TAB_URL = EXAMPLE_URL + "doc_WorkerTargetActor.attachThread-tab.html";

devtools/client/webconsole/test/browser/browser_webconsole_location_debugger_link.js

@@ -8,9 +8,6 @@
 
 // There are shutdown issues for which multiple rejections are left uncaught.
 // See bug 1018184 for resolving these issues.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
 PromiseTestUtils.whitelistRejectionsGlobally(/this\.worker is null/);
 
 requestLongerTimeout(2);

devtools/client/webconsole/test/browser/browser_webconsole_stacktrace_location_debugger_link.js

@@ -8,9 +8,6 @@
 
 // There are shutdown issues for which multiple rejections are left uncaught.
 // See bug 1018184 for resolving these issues.
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
 PromiseTestUtils.whitelistRejectionsGlobally(/Component not initialized/);
 PromiseTestUtils.whitelistRejectionsGlobally(/this\.worker is null/);
 

devtools/client/webreplay/mochitest/head.js

@@ -229,18 +229,9 @@ async function checkMessageObjectContents(msg, expected, expandList = []) {
   });
 }
 
-const { PromiseTestUtils } = ChromeUtils.import(
-  "resource://testing-common/PromiseTestUtils.jsm"
-);
 PromiseTestUtils.whitelistRejectionsGlobally(/NS_ERROR_NOT_INITIALIZED/);
 PromiseTestUtils.whitelistRejectionsGlobally(/Error in asyncStorage/);
 
-// Many web replay tests can resume execution before the debugger has finished
-// all operations related to the pause.
-PromiseTestUtils.whitelistRejectionsGlobally(
-  /Current thread has paused or resumed/
-);
-
 // When running the full test suite, long delays can occur early on in tests,
 // before child processes have even been spawned. Allow a longer timeout to
 // avoid failures from this.