зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1743379 [wpt PR 31774] - Revert "Initial support for text-decoration-line: spelling|grammar-error", a=testonly
Automatic update from web-platform-tests Revert "Initial support for text-decoration-line: spelling|grammar-error" This reverts commit 643df2d079fac73cb420e6cd074c79d5a739f63d. Reason for revert: text-decoration-line-grammar-error.html and text-decoration-line-spelling-error.html fail consistently on Mac10.12 Tests Original change's description: > Initial support for text-decoration-line: spelling|grammar-error > > This adds the initial support for spelling-error and grammar-error > values of text-decoration-line property. > > Main changes are in TextDecorationInfo, where we need to support > the new values and paint the decoration correctly. > In Mac platform we use a dotted decoration to match > the platform conventions. > In other platforms we use a wavy decoration, but we modify it > so it looks similar to the spelling and grammar markers > in Microsoft Word. > > It's important to note that this is just an intermediate step, > as this is different than how we currently paint > the spelling and grammar errors in DocumentMarkerPainter. > The idea would be make DocumentMarkerPainter use CSS text decorations > and then use this new code added here. > > There are some known issues: > * The underline offset is not the same than in Microsoft Word, > but that's because of a problem with regular underlines > not using the font metrics to compute that offset (crbug.com/1273042). > * We should allow to tweak the color with text-decoration-color, > added a TODO about that. > > BUG=1163436 > > Change-Id: I117ad38fe3fc805619eb47b1df2f48c9d7c9a351 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297885 > Commit-Queue: Delan Azabani <dazabani@igalia.com> > Reviewed-by: Delan Azabani <dazabani@igalia.com> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/main@{#945876} Bug: 1163436 Change-Id: I2622bde37f2f8a7f725a1a06be8d34acdf9f728b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306392 Auto-Submit: Greg Thompson <grt@chromium.org> Owners-Override: Greg Thompson <grt@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#945903} -- wpt-commits: 0b044312ec1d3dc5a91ab6701276fcacaca04836 wpt-pr: 31774
This commit is contained in:
Greg Thompson
moz-wptsync-bot
Родитель
dc25879aa8
Коммит
1f3c137361
|
|
@ -1,12 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: Reference</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<style>
|
||||
span {
|
||||
text-decoration-line: grammar-error;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if "quikc" has a grammar error marker that is not the default color (usually green).</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,16 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: text-decoration-line: grammar-error color</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#valdef-text-decoration-line-grammar-error">
|
||||
<meta name="assert" content="This test checks that it is possible to tweak the color of 'text-decoration-line: grammar-error' with 'text-decoration-color' property.">
|
||||
<link rel="mismatch" href="text-decoration-line-grammar-error-color-001-ref.html">
|
||||
<style>
|
||||
span {
|
||||
text-decoration-line: grammar-error;
|
||||
text-decoration-color: rgba(200, 225, 50, 0.75);
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if "quikc" has a grammar error marker that is not the default color (usually green).</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,13 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: Reference</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<style>
|
||||
div {
|
||||
padding: 10px;
|
||||
background: cyan;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if you cannot see a grammar error marker in the next sentence.</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,21 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: text-decoration-line: grammar-error color</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#valdef-text-decoration-line-grammar-error">
|
||||
<meta name="assert" content="This test checks that it is possible to tweak the color of 'text-decoration-line: grammar-error' with 'text-decoration-color' property.">
|
||||
<link rel="match" href="text-decoration-line-grammar-error-color-002-ref.html">
|
||||
<style>
|
||||
div {
|
||||
padding: 10px;
|
||||
background: cyan;
|
||||
}
|
||||
|
||||
span {
|
||||
text-decoration-line: grammar-error;
|
||||
text-decoration-color: transparent;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if you cannot see a grammar error marker in the next sentence.</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,13 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: Reference</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<style>
|
||||
span {
|
||||
text-decoration-line: grammar-error;
|
||||
text-decoration-color: magenta;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if "quikc" has a magenta grammar error marker.</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,26 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<html class="reftest-wait">
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: text-decoration-line: grammar-error color dynamic</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#valdef-text-decoration-line-grammar-error">
|
||||
<meta name="assert" content="This test checks that it is possible to dinamically tweak the color of 'text-decoration-line: grammar-error' with 'text-decoration-color' property.">
|
||||
<link rel="match" href="text-decoration-line-grammar-error-color-dynamic-001-ref.html">
|
||||
<script src="/common/reftest-wait.js"></script>
|
||||
<style>
|
||||
span {
|
||||
text-decoration-line: grammar-error;
|
||||
text-decoration-color: cyan;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if "quikc" has a magenta grammar error marker.</p>
|
||||
<div>The <span id="target">quikc</span> brown fox.</div>
|
||||
|
||||
<script>
|
||||
requestAnimationFrame(() => requestAnimationFrame(() => {
|
||||
target.style.textDecorationColor = "magenta";
|
||||
takeScreenshot();
|
||||
}));
|
||||
</script>
|
||||
</html>
|
||||
|
|
@ -1,12 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: Reference</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<style>
|
||||
span {
|
||||
text-decoration-line: spelling-error;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if "quikc" has a spelling error marker that is not the default color (usually red).</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,16 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: text-decoration-line: spelling-error color</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#valdef-text-decoration-line-spelling-error">
|
||||
<meta name="assert" content="This test checks that it is possible to tweak the color of 'text-decoration-line: spelling-error' with 'text-decoration-color' property.">
|
||||
<link rel="mismatch" href="text-decoration-line-spelling-error-color-001-ref.html">
|
||||
<style>
|
||||
span {
|
||||
text-decoration-line: spelling-error;
|
||||
text-decoration-color: rgba(200, 225, 50, 0.75);
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if "quikc" has a spelling error marker that is not the default color (usually red).</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,13 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: Reference</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<style>
|
||||
div {
|
||||
padding: 10px;
|
||||
background: cyan;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if you cannot see a spelling error marker in the next sentence.</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,21 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: text-decoration-line: spelling-error color</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#valdef-text-decoration-line-spelling-error">
|
||||
<meta name="assert" content="This test checks that it is possible to tweak the color of 'text-decoration-line: spelling-error' with 'text-decoration-color' property.">
|
||||
<link rel="match" href="text-decoration-line-spelling-error-color-002-ref.html">
|
||||
<style>
|
||||
div {
|
||||
padding: 10px;
|
||||
background: cyan;
|
||||
}
|
||||
|
||||
span {
|
||||
text-decoration-line: spelling-error;
|
||||
text-decoration-color: transparent;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if you cannot see a spelling error marker in the next sentence.</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,13 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: Reference</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<style>
|
||||
span {
|
||||
text-decoration-line: spelling-error;
|
||||
text-decoration-color: magenta;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if "quikc" has a magenta spelling error marker.</p>
|
||||
<div>The <span>quikc</span> brown fox.</div>
|
||||
|
|
@ -1,26 +0,0 @@
|
|||
<!DOCTYPE html>
|
||||
<html class="reftest-wait">
|
||||
<meta charset="utf-8" />
|
||||
<title>CSS Text Decoration Test: text-decoration-line: spelling-error color dynamic</title>
|
||||
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
|
||||
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#valdef-text-decoration-line-spelling-error">
|
||||
<meta name="assert" content="This test checks that it is possible to dinamically tweak the color of 'text-decoration-line: spelling-error' with 'text-decoration-color' property.">
|
||||
<link rel="match" href="text-decoration-line-spelling-error-color-dynamic-001-ref.html">
|
||||
<script src="/common/reftest-wait.js"></script>
|
||||
<style>
|
||||
span {
|
||||
text-decoration-line: spelling-error;
|
||||
text-decoration-color: cyan;
|
||||
}
|
||||
</style>
|
||||
|
||||
<p>The test passes if "quikc" has a magenta spelling error marker.</p>
|
||||
<div>The <span id="target">quikc</span> brown fox.</div>
|
||||
|
||||
<script>
|
||||
requestAnimationFrame(() => requestAnimationFrame(() => {
|
||||
target.style.textDecorationColor = "magenta";
|
||||
takeScreenshot();
|
||||
}));
|
||||
</script>
|
||||
</html>
|
||||
Загрузка…
Ссылка в новой задаче