Bug 418752: don't bother fetching forwards on a failed safebrowsing update. r=tony, a=beltzner

toolkit/components/url-classifier/public/nsIUrlClassifierDBService.idl

@@ -69,8 +69,12 @@ interface nsIUrlClassifierUpdateObserver : nsISupports {
    */
   void updateUrlRequested(in ACString url, in ACString table);
 
-  /* A stream update has completed */
-  void streamFinished();
+  /**
+   * A stream update has completed.
+   *
+   * @param status The state of the update process.
+   */
+  void streamFinished(in nsresult status);
 
   /* The update has encountered an error and should be cancelled */
   void updateError(in nsresult error);

toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp

@@ -2536,7 +2536,7 @@ nsUrlClassifierDBServiceWorker::FinishStream()
   NS_ENSURE_STATE(mInStream);
   NS_ENSURE_STATE(mUpdateObserver);
 
-  mUpdateObserver->StreamFinished();
+  mUpdateObserver->StreamFinished(mUpdateStatus);
 
   ResetStream();
 

toolkit/components/url-classifier/src/nsUrlClassifierStreamUpdater.cpp

@@ -249,12 +249,12 @@ nsUrlClassifierStreamUpdater::UpdateUrlRequested(const nsACString &aUrl,
 }
 
 NS_IMETHODIMP
-nsUrlClassifierStreamUpdater::StreamFinished()
+nsUrlClassifierStreamUpdater::StreamFinished(nsresult status)
 {
   nsresult rv;
 
   // Pop off a pending URL and update it.
-  if (mPendingUpdates.Length() > 0) {
+  if (NS_SUCCEEDED(status) && mPendingUpdates.Length() > 0) {
     PendingUpdate &update = mPendingUpdates[0];
     rv = FetchUpdate(update.mUrl, EmptyCString(), update.mTable);
     if (NS_FAILED(rv)) {