Bug 1271507 - Ensure the SourceCompressionTask becomes inactive on OOM; r=jimb

js/src/jit-test/tests/basic/bug-1271507-2.js

@@ -0,0 +1,4 @@
+// |jit-test| allow-oom
+
+// Adapted from randomly chosen testcase: js/src/jit-test/tests/debug/bug-1238610.js
+load(libdir + "../tests/basic/bug-1271507.js");

js/src/vm/HelperThreads.cpp

@@ -1629,6 +1629,8 @@ SourceCompressionTask::complete()
         if (!ss->setCompressedSource(cx, mozilla::Move(compressedSource), compressedBytes,
                                      ss->length()))
         {
+            ss = nullptr;
+            MOZ_ASSERT(!active());
             return false;
         }
     } else {

js/src/vm/SharedImmutableStringsCache.cpp

@@ -111,6 +111,7 @@ MOZ_MUST_USE mozilla::Maybe<SharedImmutableString>
 SharedImmutableStringsCache::getOrCreate(OwnedChars&& chars, size_t length)
 {
     OwnedChars owned(mozilla::Move(chars));
+    MOZ_ASSERT(owned);
     return getOrCreate(owned.get(), length, [&]() { return mozilla::Move(owned); });
 }
 
@@ -124,6 +125,7 @@ MOZ_MUST_USE mozilla::Maybe<SharedImmutableTwoByteString>
 SharedImmutableStringsCache::getOrCreate(OwnedTwoByteChars&& chars, size_t length)
 {
     OwnedTwoByteChars owned(mozilla::Move(chars));
+    MOZ_ASSERT(owned);
     return getOrCreate(owned.get(), length, [&]() { return mozilla::Move(owned); });
 }