Bug 1305325 - Part 3: Make AnimationPropertyValueDetails::mValue optional. r=birtles,smaug

MozReview-Commit-ID: H2fhRfC0Uoh

dom/animation/KeyframeEffectReadOnly.cpp

@@ -800,11 +800,13 @@ CreatePropertyValue(nsCSSPropertyID aProperty,
 {
   aResult.mOffset = aOffset;
 
-  nsString stringValue;
+  if (!aValue.IsNull()) {
-  DebugOnly<bool> uncomputeResult =
+    nsString stringValue;
-    StyleAnimationValue::UncomputeValue(aProperty, aValue, stringValue);
+    DebugOnly<bool> uncomputeResult =
-  MOZ_ASSERT(uncomputeResult, "failed to uncompute value");
+      StyleAnimationValue::UncomputeValue(aProperty, aValue, stringValue);
-  aResult.mValue = stringValue;
+    MOZ_ASSERT(uncomputeResult, "failed to uncompute value");
+    aResult.mValue.Construct(stringValue);
+  }
 
   if (aTimingFunction) {
     aResult.mEasing.Construct();

dom/webidl/KeyframeEffect.webidl

@@ -45,7 +45,7 @@ interface KeyframeEffectReadOnly : AnimationEffectReadOnly {
 // Non-standard extensions
 dictionary AnimationPropertyValueDetails {
   required double             offset;
-  required DOMString          value;
+           DOMString          value;
            DOMString          easing;
   required CompositeOperation composite;
 };