Backed out 5 changesets (bug 1740438) for causing xpcshell failures on test_action-toggle-recording-allocations.js CLOSED TREE

Backed out changeset 28518fbe3077 (bug 1740438)
Backed out changeset f33ea874875c (bug 1740438)
Backed out changeset f20e36b0d1d4 (bug 1740438)
Backed out changeset 2f166a7bc13b (bug 1740438)
Backed out changeset 9d9bcf855ceb (bug 1740438)

devtools/client/debugger/src/client/firefox/commands.js

@@ -334,7 +334,11 @@ async function setSkipPausing(shouldSkip) {
 }
 
 async function setEventListenerBreakpoints(ids) {
-  const hasWatcherSupport = commands.targetCommand.hasTargetWatcherSupport();
+  // @backward-compat { version 94 } The `event-breakpoints` trait check is no longer needed, but
+  // keep the check for target watcher support to fallback for unsupported targets (e.g webextensions)
+  const hasWatcherSupport = commands.targetCommand.hasTargetWatcherSupport(
+    "event-breakpoints"
+  );
   if (!hasWatcherSupport) {
     return forEachThread(thread => thread.setActiveEventBreakpoints(ids));
   }

devtools/client/fronts/accessibility.js

@@ -47,8 +47,10 @@ class AccessibleFront extends FrontClassWithSpec(accessibleSpec) {
     if (!BROWSER_TOOLBOX_FISSION_ENABLED && this.targetFront.isParentProcess) {
       return false;
     }
-
-    return this._form.useChildTargetToFetchChildren;
+    // @backward-compat { version 94 } useChildTargetToFetchChildren was added in 94, so
+    // we still need to check for `remoteFrame` when connecting to older server.
+    // When 94 is in release, we can check useChildTargetToFetchChildren only
+    return this._form.useChildTargetToFetchChildren || this._form.remoteFrame;
   }
 
   get role() {

devtools/client/fronts/node.js

@@ -312,7 +312,10 @@ class NodeFront extends FrontClassWithSpec(nodeSpec) {
       return false;
     }
 
-    return this._form.useChildTargetToFetchChildren;
+    // @backward-compat { version 94 } useChildTargetToFetchChildren was added in 94, so
+    // we still need to check for `remoteFrame` when connecting to older server.
+    // When 94 is in release, we can check useChildTargetToFetchChildren only
+    return this._form.useChildTargetToFetchChildren || this._form.remoteFrame;
   }
   get hasEventListeners() {
     return this._form.hasEventListeners;

devtools/client/fronts/targets/target-mixin.js

@@ -367,7 +367,11 @@ function TargetMixin(parentClass) {
     // interface and requires to call `attach` request before being used and
     // `detach` during cleanup.
     get isBrowsingContext() {
-      return this.typeName === "windowGlobalTarget";
+      // @backward-compat { version 94 } Fx 94 renamed typeName from browsingContextTarget to windowGlobalTarget
+      return (
+        this.typeName === "windowGlobalTarget" ||
+        this.typeName == "browsingContextTarget"
+      );
     }
 
     get name() {

devtools/client/inspector/node-picker.js

@@ -219,6 +219,12 @@ class NodePicker extends EventEmitter {
   _onHovered(data) {
     this.emit("picker-node-hovered", data.node);
 
+    // @backward-compat { version 94 } The clearPickerSupport trait was added in 94 and
+    // can be removed when it hits release.
+    if (!data.node.walkerFront.traits.clearPickerSupport) {
+      return;
+    }
+
     // We're going to cleanup references for all the other walkers, so that if we hover
     // back the same node, we will receive a new `picker-node-hovered` event.
     for (const inspectorFront of this._currentInspectorFronts) {

devtools/client/memory/actions/allocations.js

@@ -12,8 +12,12 @@ exports.toggleRecordingAllocationStacks = function(commands) {
   return async function({ dispatch, getState }) {
     dispatch({ type: actions.TOGGLE_RECORD_ALLOCATION_STACKS_START });
 
-    if (commands.targetCommand.hasTargetWatcherSupport()) {
-      await commands.targetConfigurationCommand.updateConfiguration({
+    const { targetConfigurationCommand } = commands;
+    // @backward-compat { version 94 } Starts supporting "recordAllocations" configuration in order to better support SSTS
+    // Could only be dropped once we support targetConfiguration for all toolboxes (either we drop the Browser content toolbox, or support the content process in watcher actor)
+    // Once Fx93 support is removed, we can replace this check with `commands.targetCommand.hasTargetWatcherSupport()` to check if the watcher is supported.
+    if (targetConfigurationCommand.supports("recordAllocations")) {
+      await targetConfigurationCommand.updateConfiguration({
         recordAllocations: getState().recordingAllocationStacks
           ? null
           : ALLOCATION_RECORDING_OPTIONS,

devtools/server/actors/inspector/walker.js

@@ -321,7 +321,10 @@ var WalkerActor = protocol.ActorClassWithSpec(walkerSpec, {
     return {
       actor: this.actorID,
       root: this.rootNode.form(),
-      traits: {},
+      traits: {
+        // @backward-compat { version 94 } This can be removed once 94 is in release
+        clearPickerSupport: true,
+      },
     };
   },
 

devtools/server/actors/watcher.js

@@ -238,6 +238,9 @@ exports.WatcherActor = protocol.ActorClassWithSpec(watcherSpec, {
           [Resources.TYPES.SERVER_SENT_EVENT]: shouldEnableAllWatchers,
           [Resources.TYPES.WEBSOCKET]: shouldEnableAllWatchers,
         },
+
+        // @backward-compat { version 94 } Full support for event breakpoints via the watcher actor
+        "event-breakpoints": true,
       },
     };
   },

devtools/shared/commands/target/target-command.js

@@ -570,7 +570,11 @@ class TargetCommand extends EventEmitter {
 
   getTargetType(target) {
     const { typeName } = target;
-    if (typeName == "windowGlobalTarget") {
+    // @backward-compat { version 94 } Fx 94 renamed typeName from browsingContextTarget to windowGlobalTarget
+    if (
+      typeName == "windowGlobalTarget" ||
+      typeName == "browsingContextTarget"
+    ) {
       return TargetCommand.TYPES.FRAME;
     }