Bug 1383120 - Enable no-arbitrary-setTimeout eslint rule on xpcshell tests, r=mossop

MozReview-Commit-ID: 6DqLaZ9n5EM

--HG--
extra : rebase_source : 5f1264bb3ea23005c91557e5db4ce5f9e167ce9a

browser/components/extensions/test/xpcshell/test_ext_browsingData_cookies_cache.js

@@ -1,5 +1,6 @@
 /* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* vim: set sts=2 sw=2 et tw=80: */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 "use strict";
 
 XPCOMUtils.defineLazyModuleGetter(this, "setTimeout",

browser/components/translation/test/unit/test_cld2.js

@@ -17,6 +17,7 @@
 //
 // Unit test compact language detector, CLD2
 //
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 // Test strings.
 const kTeststr_en =

browser/experiments/test/xpcshell/test_cacherace.js

@@ -1,5 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 "use strict";
 

browser/extensions/formautofill/test/unit/test_autofillFormFields.js

@@ -1,6 +1,7 @@
 /*
  * Test for form auto fill content helper fill all inputs function.
  */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 "use strict";
 

devtools/server/tests/unit/test_promises_object_timetosettle-02.js

@@ -1,5 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
    http://creativecommons.org/publicdomain/zero/1.0/ */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 /**
  * Test that we get the expected settlement time for promise time to settle.

devtools/shared/discovery/tests/unit/test_discovery.js

@@ -1,5 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
    http://creativecommons.org/publicdomain/zero/1.0/ */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 "use strict";
 

dom/indexedDB/test/unit/test_database_close_without_onclose.js

@@ -2,6 +2,7 @@
  * Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/
  */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 var testGenerator = testSteps();
 

dom/indexedDB/test/unit/test_idle_maintenance.js

@@ -2,6 +2,7 @@
  * Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/
  */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 var testGenerator = testSteps();
 

dom/indexedDB/test/unit/test_temporary_storage.js

@@ -2,6 +2,7 @@
  * Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/
  */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 var testGenerator = testSteps();
 

dom/indexedDB/test/unit/test_writer_starvation.js

@@ -2,6 +2,7 @@
  * Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/
  */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 if (!this.window) {
   this.runTest = function() {

toolkit/components/extensions/test/xpcshell/test_ext_alarms.js

@@ -1,5 +1,6 @@
 /* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* vim: set sts=2 sw=2 et tw=80: */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 "use strict";
 
 add_task(async function test_alarm_without_permissions() {

toolkit/components/extensions/test/xpcshell/test_ext_alarms_does_not_fire.js

@@ -1,5 +1,6 @@
 /* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* vim: set sts=2 sw=2 et tw=80: */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 "use strict";
 
 add_task(async function test_cleared_alarm_does_not_fire() {

toolkit/components/extensions/test/xpcshell/test_ext_alarms_periodic.js

@@ -1,5 +1,6 @@
 /* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* vim: set sts=2 sw=2 et tw=80: */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 "use strict";
 
 add_task(async function test_periodic_alarm_fires() {

toolkit/components/promiseworker/tests/xpcshell/test_Promise.js

@@ -1,5 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 "use strict";
 

toolkit/components/search/tests/xpcshell/test_searchSuggest.js

@@ -1,5 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 /**
  * Testing search suggestions from SearchSuggestionController.jsm.

toolkit/components/telemetry/tests/unit/test_PingSender.js

@@ -1,6 +1,7 @@
 /* Any copyright is dedicated to the Public Domain.
    http://creativecommons.org/publicdomain/zero/1.0/
 */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 // This tests submitting a ping using the stand-alone pingsender program.
 

toolkit/components/terminator/tests/xpcshell/test_terminator_record.js

@@ -1,5 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 "use strict";
 

toolkit/modules/subprocess/test/xpcshell/test_subprocess.js

@@ -1,3 +1,4 @@
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 "use strict";
 
 Cu.import("resource://gre/modules/AppConstants.jsm");

toolkit/modules/tests/xpcshell/test_GMPInstallManager.js

@@ -1,5 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 var {classes: Cc, interfaces: Ci, results: Cr, utils: Cu, manager: Cm} = Components;
 const URL_HOST = "http://localhost";

toolkit/modules/tests/xpcshell/test_PromiseUtils.js

@@ -1,5 +1,6 @@
   /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
+/* eslint-disable mozilla/no-arbitrary-setTimeout */
 
 "use strict";
 

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/xpcshell-test.js

@@ -69,6 +69,7 @@ module.exports = {
   rules: {
     "mozilla/import-headjs-globals": "warn",
     "mozilla/mark-test-function-used": "warn",
+    "mozilla/no-arbitrary-setTimeout": "error",
     "no-shadow": "error"
   }
 };