From 23508bb09f0cd981948bd8b1dbd7266c2650510c Mon Sep 17 00:00:00 2001 From: Itiel Date: Mon, 6 Apr 2020 17:03:00 +0000 Subject: [PATCH] Bug 1627477 - Convert all relevant uses of left/right to logical properties in browser/themes/windows r=dao Differential Revision: https://phabricator.services.mozilla.com/D69722 --HG-- extra : moz-landing-system : lando --- browser/themes/windows/browser-aero.css | 12 +++------ browser/themes/windows/browser.css | 27 +++++++------------ browser/themes/windows/compacttheme.css | 3 +-- browser/themes/windows/places/organizer.css | 17 +++++------- browser/themes/windows/syncedtabs/sidebar.css | 2 +- 5 files changed, 22 insertions(+), 39 deletions(-) diff --git a/browser/themes/windows/browser-aero.css b/browser/themes/windows/browser-aero.css index 94c343dc7fb2..a76d70cb2103 100644 --- a/browser/themes/windows/browser-aero.css +++ b/browser/themes/windows/browser-aero.css @@ -164,8 +164,7 @@ /* 175% dpi should result in the same device pixel sizes as 150% dpi. */ @media (min-resolution: 1.70dppx) and (max-resolution: 1.95dppx) { .titlebar-button { - padding-left: 14.1px; - padding-right: 14.1px; + padding-inline: 14.1px; } .titlebar-button > .toolbarbutton-icon { @@ -177,8 +176,7 @@ /* 225% dpi should result in the same device pixel sizes as 200% dpi. */ @media (min-resolution: 2.20dppx) and (max-resolution: 2.45dppx) { .titlebar-button { - padding-left: 15.3333px; - padding-right: 15.3333px; + padding-inline: 15.3333px; } .titlebar-button > .toolbarbutton-icon { @@ -303,8 +301,7 @@ /* Vertical toolbar border */ #main-window[sizemode=normal] .browser-toolbar:not(.titlebar-color):not(:-moz-lwtheme), #main-window[sizemode=normal] .browser-toolbar:-moz-lwtheme { - border-left: 1px solid @glassShadowColor@; - border-right: 1px solid @glassShadowColor@; + border-inline: 1px solid @glassShadowColor@; background-clip: padding-box; } @@ -321,8 +318,7 @@ :root[sizemode=normal] #navigator-toolbox::after { box-shadow: 1px 0 0 @glassShadowColor@, -1px 0 0 @glassShadowColor@; - margin-left: 1px; - margin-right: 1px; + margin-inline: 1px; } #main-window[sizemode=normal] #browser-border-start, diff --git a/browser/themes/windows/browser.css b/browser/themes/windows/browser.css index 4eb37e9489a2..fb314c646f41 100644 --- a/browser/themes/windows/browser.css +++ b/browser/themes/windows/browser.css @@ -349,12 +349,11 @@ menuitem.bookmark-item { } .bookmark-item:not(.subviewbutton) > .menu-iconic-left { - margin-top: 0; - margin-bottom: 0; + margin-block: 0; } .bookmark-item > .menu-iconic-left > .menu-iconic-icon { - padding-inline-start: 0px; + padding-inline-start: 0; } .bookmark-item[cutting] > .toolbarbutton-icon, @@ -565,11 +564,11 @@ menuitem.bookmark-item { } } -/* bookmarking panel */ +/* Bookmarking panel */ %include ../shared/places/editBookmarkPanel.inc.css -/* ::::: content area ::::: */ +/* ::::: Content area ::::: */ %include ../shared/sidebar.inc.css @@ -807,8 +806,7 @@ notification[value="translation"] { * Override the --arrowpanel-padding so the background extends * to the sides and bottom of the panel. */ - margin-left: -10px; - margin-right: -10px; + margin-inline: -10px; margin-bottom: -10px; } @@ -819,19 +817,16 @@ notification[value="translation"] { panel[touchmode] .PanelUI-subView .subviewbutton, menupopup[touchmode] menu, menupopup[touchmode] menuitem { - padding-top: 12px; - padding-bottom: 12px; + padding-block: 12px; } panel[touchmode] .PanelUI-subView #appMenu-edit-controls > .subviewbutton, panel[touchmode] .PanelUI-subView #appMenu-zoom-controls > .subviewbutton-iconic { - padding-inline-start: 12px; - padding-inline-end: 12px; + padding-inline: 12px; } #contentAreaContextMenu[touchmode] > #context-navigation > menuitem { - padding-top: 7px; - padding-bottom: 7px; + padding-block: 7px; } #context-navigation { @@ -875,8 +870,7 @@ panel[touchmode] .PanelUI-subView #appMenu-zoom-controls > .subviewbutton-iconic #ContentSelectDropdown > menupopup > menuitem > .menu-iconic-text { /* Padding should follow the 4/12 ratio, where 12px is the default font-size with 4px being the preferred padding size. */ - padding-top: .3333em; - padding-bottom: .3333em; + padding-block: .3333em; } #ContentSelectDropdown > menupopup > menucaption > .menu-iconic-text { @@ -900,6 +894,5 @@ panel[touchmode] .PanelUI-subView #appMenu-zoom-controls > .subviewbutton-iconic #ContentSelectDropdown > .isOpenedViaTouch > menuitem > .menu-iconic-text { /* Touch padding should follow the 11/12 ratio, where 12px is the default font-size with 11px being the preferred padding size. */ - padding-top: .9167em; - padding-bottom: .9167em; + padding-block: .9167em; } diff --git a/browser/themes/windows/compacttheme.css b/browser/themes/windows/compacttheme.css index a642cc854a47..89fd49be53ed 100644 --- a/browser/themes/windows/compacttheme.css +++ b/browser/themes/windows/compacttheme.css @@ -73,8 +73,7 @@ /* Remove lwtheme borders from toolbars in non-maximized windows. */ #toolbar-menubar, #TabsToolbar { - border-left-style: none !important; - border-right-style: none !important; + border-inline-style: none !important; } } diff --git a/browser/themes/windows/places/organizer.css b/browser/themes/windows/places/organizer.css index 7c37b2540cdb..2f5f6ac174b3 100644 --- a/browser/themes/windows/places/organizer.css +++ b/browser/themes/windows/places/organizer.css @@ -37,10 +37,8 @@ } #placesMenu > menu { - padding-inline-start: 4px; - padding-inline-end: 1px; - padding-top: 2px; - padding-bottom: 2px; + padding-block: 2px; + padding-inline: 4px 1px; -moz-appearance: toolbarbutton; %ifdef XP_WIN % use standard menu colors on OS/2 @@ -59,10 +57,8 @@ #placesMenu > menu[open="true"] { border-color: ThreeDShadow ThreeDHighlight ThreeDHighlight ThreeDShadow; - padding-inline-start: 5px; - padding-inline-end: 0px; - padding-top: 3px; - padding-bottom: 1px; + padding-block: 3px 1px; + padding-inline: 5px 0; } #placesMenu > menu > .menubar-text { @@ -71,7 +67,7 @@ } #placesMenu > menu > .menubar-text:-moz-locale-dir(rtl) { - background-position: left center; + background-position-x: left; } /* organize button */ @@ -112,8 +108,7 @@ } #clearDownloadsButton { - padding-inline-start: 9px; - padding-inline-end: 9px; + padding-inline: 9px; } @media (-moz-windows-classic: 0) { diff --git a/browser/themes/windows/syncedtabs/sidebar.css b/browser/themes/windows/syncedtabs/sidebar.css index 6eb29e15fedb..ac0c46a953b9 100644 --- a/browser/themes/windows/syncedtabs/sidebar.css +++ b/browser/themes/windows/syncedtabs/sidebar.css @@ -23,7 +23,7 @@ max-width: 16px; min-height: 16px; max-height: 16px; - margin-right: 5px; + margin-inline-end: 5px; background-size: 16px 16px; background-repeat: no-repeat; background-position: center;