Bug 1049975 - Part 1: Support null effect. r=birtles

MozReview-Commit-ID: 7ougqvbIVuD

--HG--
extra : rebase_source : 92f4095c7fb5ebcd555a2c2305a7db06024e2984

dom/animation/Animation.cpp

@@ -94,12 +94,6 @@ Animation::Constructor(const GlobalObject& aGlobal,
   nsCOMPtr<nsIGlobalObject> global = do_QueryInterface(aGlobal.GetAsSupports());
   RefPtr<Animation> animation = new Animation(global);
 
-  if (!aEffect) {
-    // Bug 1049975: We do not support null effect yet.
-    aRv.Throw(NS_ERROR_DOM_ANIM_NO_EFFECT_ERR);
-    return nullptr;
-  }
-
   AnimationTimeline* timeline;
   if (aTimeline.WasPassed()) {
     timeline = aTimeline.Value();
@@ -1126,6 +1120,10 @@ Animation::PostUpdate()
     return;
   }
 
+  if (!mEffect) {
+    return;
+  }
+
   Maybe<NonOwningAnimationTarget> target = mEffect->GetTarget();
   if (!target) {
     return;

dom/base/domerr.msg

@@ -119,7 +119,6 @@ DOM4_MSG_DEF(BtAuthRejectedError, "Authentication rejected",  NS_ERROR_DOM_BLUET
 /* Web Animations errors */
 
 DOM4_MSG_DEF(NotSupportedError, "Animation to or from an underlying value is not yet supported.", NS_ERROR_DOM_ANIM_MISSING_PROPS_ERR)
-DOM4_MSG_DEF(NotSupportedError, "Animation with no effect is not yet supported.", NS_ERROR_DOM_ANIM_NO_EFFECT_ERR)
 
 /* common global codes (from nsError.h) */
 

testing/web-platform/meta/web-animations/interfaces/Animation/constructor.html.ini

@@ -1,14 +0,0 @@
-[constructor.html]
-  type: testharness
-  [Animation can be constructed with null effect and null timeline]
-    expected: FAIL
-    bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1049975
-
-  [Animation can be constructed with null effect and non-null timeline]
-    expected: FAIL
-    bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1049975
-
-  [Animation can be constructed with null effect and no timeline parameter]
-    expected: FAIL
-    bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1049975
-

xpcom/base/ErrorList.h

@@ -954,7 +954,6 @@
   /* ======================================================================= */
 #define MODULE NS_ERROR_MODULE_DOM_ANIM
   ERROR(NS_ERROR_DOM_ANIM_MISSING_PROPS_ERR,              FAILURE(1)),
-  ERROR(NS_ERROR_DOM_ANIM_NO_EFFECT_ERR,                  FAILURE(2)),
 #undef MODULE
 
   /* ======================================================================= */