Bug 1729447 - Changed downloads context menu string for non-Mac from "Open Containing Folder" to "Show in Folder" to align terminology. r=mak,fluent-reviewers,flod

Differential Revision: https://phabricator.services.mozilla.com/D128538

browser/components/downloads/DownloadsViewUI.jsm

@@ -63,9 +63,9 @@ var gDownloadElementButtons = {
   },
   show: {
     commandName: "downloadsCmd_show",
-    l10nId: "downloads-cmd-show-button",
-    descriptionL10nId: "downloads-cmd-show-description",
-    panelL10nId: "downloads-cmd-show-panel",
+    l10nId: "downloads-cmd-show-button-2",
+    descriptionL10nId: "downloads-cmd-show-description-2",
+    panelL10nId: "downloads-cmd-show-panel-2",
     iconClass: "downloadIconShow",
   },
   subviewOpenOrRemoveFile: {

browser/components/downloads/content/downloadsContextMenu.inc.xhtml

@@ -22,12 +22,7 @@
             data-l10n-id="downloads-cmd-always-use-system-default"/>
   <menuitem command="downloadsCmd_show"
             class="downloadShowMenuItem"
-#ifdef XP_MACOSX
-            data-l10n-id="downloads-cmd-show-menuitem-mac"
-#else
-            data-l10n-id="downloads-cmd-show-menuitem"
-#endif
-            />
+            data-l10n-id="downloads-cmd-show-menuitem-2"/>
 
   <menuseparator class="downloadCommandsSeparator"/>
 

browser/components/downloads/content/downloadsPanel.inc.xhtml

@@ -85,12 +85,7 @@
               data-l10n-id="downloads-cmd-always-use-system-default"/>
     <menuitem command="downloadsCmd_show"
               class="downloadShowMenuItem"
-  #ifdef XP_MACOSX
-              data-l10n-id="downloads-cmd-show-menuitem-mac"
-  #else
-              data-l10n-id="downloads-cmd-show-menuitem"
-  #endif
-              />
+              data-l10n-id="downloads-cmd-show-menuitem-2"/>
 
     <menuseparator class="downloadCommandsSeparator"/>
 

browser/locales/en-US/browser/downloads.ftl

@@ -29,14 +29,11 @@ downloads-cmd-cancel =
 downloads-cmd-cancel-panel =
     .aria-label = Cancel
 
-# This message is only displayed on Windows and Linux devices
-downloads-cmd-show-menuitem =
-  .label = Open Containing Folder
-  .accesskey = F
-
-# This message is only displayed on macOS devices
-downloads-cmd-show-menuitem-mac =
-  .label = Show In Finder
+downloads-cmd-show-menuitem-2 =
+  .label = { PLATFORM() ->
+      [macos] Show in Finder
+     *[other] Show in Folder
+  }
   .accesskey = F
 
 downloads-cmd-use-system-default =
@@ -47,21 +44,21 @@ downloads-cmd-always-use-system-default =
   .label = Always Open In System Viewer
   .accesskey = w
 
-downloads-cmd-show-button =
+downloads-cmd-show-button-2 =
   .tooltiptext = { PLATFORM() ->
-      [macos] Show In Finder
-     *[other] Open Containing Folder
+      [macos] Show in Finder
+     *[other] Show in Folder
   }
 
-downloads-cmd-show-panel =
+downloads-cmd-show-panel-2 =
   .aria-label = { PLATFORM() ->
-      [macos] Show In Finder
-     *[other] Open Containing Folder
+      [macos] Show in Finder
+     *[other] Show in Folder
   }
-downloads-cmd-show-description =
+downloads-cmd-show-description-2 =
   .value = { PLATFORM() ->
-      [macos] Show In Finder
-     *[other] Open Containing Folder
+      [macos] Show in Finder
+     *[other] Show in Folder
   }
 
 downloads-cmd-show-downloads =

browser/locales/en-US/chrome/browser/downloads/downloads.properties

@@ -82,17 +82,3 @@ statusSeparatorBeforeNumber=%1$S \u2014  %2$S
 # semi-colon list of plural forms.
 # See: http://developer.mozilla.org/en/Localization_and_Plurals
 otherDownloads3=%1$S file downloading;%1$S files downloading
-
-# LOCALIZATION NOTE (showLabel, showMacLabel):
-# This is displayed when you hover a download item in the Library widget view.
-# showMacLabel is only shown on Mac OSX.
-showLabel=Open Containing Folder
-showMacLabel=Open In Finder
-# LOCALIZATION NOTE (openFileLabel):
-# Displayed when hovering a complete download, indicates that it's possible to
-# open the file using an app available in the system.
-openFileLabel=Open File
-# LOCALIZATION NOTE (retryLabel):
-# Displayed when hovering a download which is able to be retried by users,
-# indicates that it's possible to download this file again.
-retryLabel=Retry Download