зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1364661 - Remove _fillTrailingGap. r=florian
This was working around some old XUL layout weirdness, but nowadays this uses the same scroll frame implementation as HTML and tabStrip.scrollPosition + tabStrip.scrollClientSize > tabStrip.scrollSize cannot be true. MozReview-Commit-ID: F5fOEpXn8ay --HG-- extra : rebase_source : 5dcd0282e1054aad1c1a4946dd98dc33549bd2d6
This commit is contained in:
Родитель
1db9c8b4d0
Коммит
252945d708
|
@ -2868,7 +2868,6 @@
|
|||
|
||||
// update the UI early for responsiveness
|
||||
aTab.collapsed = true;
|
||||
this.tabContainer._fillTrailingGap();
|
||||
this._blurTab(aTab);
|
||||
|
||||
this._removingTabs.splice(this._removingTabs.indexOf(aTab), 1);
|
||||
|
@ -6028,21 +6027,6 @@
|
|||
]]></body>
|
||||
</method>
|
||||
|
||||
<method name="_fillTrailingGap">
|
||||
<body><![CDATA[
|
||||
try {
|
||||
// if we're at the right side (and not the logical end,
|
||||
// which is why this works for both LTR and RTL)
|
||||
// of the tabstrip, we need to ensure that we stay
|
||||
// completely scrolled to the right side
|
||||
var tabStrip = this.mTabstrip;
|
||||
if (tabStrip.scrollPosition + tabStrip.scrollClientSize >
|
||||
tabStrip.scrollSize)
|
||||
tabStrip.scrollByPixels(-1);
|
||||
} catch (e) {}
|
||||
]]></body>
|
||||
</method>
|
||||
|
||||
<field name="_closingTabsSpacer">
|
||||
document.getAnonymousElementByAttribute(this, "anonid", "closing-tabs-spacer");
|
||||
</field>
|
||||
|
@ -6332,7 +6316,6 @@
|
|||
var width = this.mTabstrip.boxObject.width;
|
||||
if (width != this.mTabstripWidth) {
|
||||
this.adjustTabstrip();
|
||||
this._fillTrailingGap();
|
||||
this._handleTabSelect(false);
|
||||
this.mTabstripWidth = width;
|
||||
}
|
||||
|
@ -6487,7 +6470,6 @@
|
|||
this.adjustTabstrip();
|
||||
|
||||
if (tab.getAttribute("selected") == "true") {
|
||||
this._fillTrailingGap();
|
||||
this._handleTabSelect();
|
||||
} else if (!tab.hasAttribute("skipbackgroundnotify")) {
|
||||
this._notifyBackgroundTab(tab);
|
||||
|
|
|
@ -23,18 +23,6 @@ const EXPECTED_REFLOWS = [
|
|||
"openUILinkIn@chrome://browser/content/utilityOverlay.js|" +
|
||||
"BrowserOpenTab@chrome://browser/content/browser.js|",
|
||||
|
||||
// accessing element.scrollPosition in _fillTrailingGap() flushes layout
|
||||
"get_scrollPosition@chrome://global/content/bindings/scrollbox.xml|" +
|
||||
"_fillTrailingGap@chrome://browser/content/tabbrowser.xml|" +
|
||||
"_handleNewTab@chrome://browser/content/tabbrowser.xml|" +
|
||||
"onxbltransitionend@chrome://browser/content/tabbrowser.xml|",
|
||||
|
||||
// SessionStore.getWindowDimensions()
|
||||
"ssi_getWindowDimension@resource:///modules/sessionstore/SessionStore.jsm|" +
|
||||
"ssi_updateWindowFeatures/<@resource:///modules/sessionstore/SessionStore.jsm|" +
|
||||
"ssi_updateWindowFeatures@resource:///modules/sessionstore/SessionStore.jsm|" +
|
||||
"ssi_collectWindowData@resource:///modules/sessionstore/SessionStore.jsm|",
|
||||
|
||||
// selection change notification may cause querying the focused editor content
|
||||
// by IME and that will cause reflow.
|
||||
"select@chrome://global/content/bindings/textbox.xml|" +
|
||||
|
|
|
@ -54,7 +54,6 @@ involved:
|
|||
* `filter.addProgressListener`
|
||||
* `ourBrowser.webProgress.addProgressListener`
|
||||
* `gBrowser._endRemoveTab`
|
||||
* `gBrowser.tabContainer._fillTrailingGap`
|
||||
* `gBrowser._blurTab`
|
||||
* `gBrowser._tabFilters.delete`
|
||||
* `gBrowser._tabListeners.delete`
|
||||
|
|
Загрузка…
Ссылка в новой задаче