Bug 434247

Remove mozStorageStatement's mStatementString
r=vlad

storage/src/mozStorageStatement.cpp

@@ -137,7 +137,6 @@ mozStorageStatement::Initialize(mozIStorageConnection *aDBConnection, const nsAC
     }
 
     mDBConnection = aDBConnection;
-    mStatementString.Assign (aSQLStatement);
     mParamCount = sqlite3_bind_parameter_count (mDBStatement);
     mResultColumnCount = sqlite3_column_count (mDBStatement);
     mColumnNames.Clear();
@@ -204,7 +203,8 @@ mozStorageStatement::Clone(mozIStorageStatement **_retval)
     if (!mss)
       return NS_ERROR_OUT_OF_MEMORY;
 
-    nsresult rv = mss->Initialize (mDBConnection, mStatementString);
+    nsCAutoString sql(sqlite3_sql(mDBStatement));
+    nsresult rv = mss->Initialize (mDBConnection, sql);
     NS_ENSURE_SUCCESS(rv, rv);
 
     NS_ADDREF(*_retval = mss);
@@ -338,7 +338,8 @@ mozStorageStatement::Reset()
     if (!mDBConnection || !mDBStatement)
         return NS_ERROR_NOT_INITIALIZED;
 
-    PR_LOG(gStorageLog, PR_LOG_DEBUG, ("Resetting statement: '%s'", nsPromiseFlatCString(mStatementString).get()));
+    PR_LOG(gStorageLog, PR_LOG_DEBUG, ("Resetting statement: '%s'",
+                                       sqlite3_sql(mDBStatement)));
 
     sqlite3_reset(mDBStatement);
     sqlite3_clear_bindings(mDBStatement);

storage/src/mozStorageStatement.h

@@ -63,7 +63,6 @@ private:
     ~mozStorageStatement();
 
 protected:
-    nsCString mStatementString;
     nsCOMPtr<mozIStorageConnection> mDBConnection;
     sqlite3_stmt *mDBStatement;
     PRUint32 mParamCount;