зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1860685 - Vendor libwebrtc from 0fa90c3878
Upstream commit: https://webrtc.googlesource.com/src/+/0fa90c387838b2c2b53067d2e51fcbf3fd78980c Reland "Per default enable RobustThroughputEstimator" This reverts commit 4ef01d41b73c1543abf1096e64406ae5233d0230. Reason for revert: Downstream projects fixed Original change's description: > Revert "Per default enable RobustThroughputEstimator" > > This reverts commit d017b1e306186252ed52ab84459d05efc4eb9fd4. > > Reason for revert: Breaks downstream test. > > Original change's description: > > Per default enable RobustThroughputEstimator > > > > Experiments has not showed significant metric changes. However, simulations has showed that RobustThroughputEstimator better follow the actually receive rate better. Especially during bursts of sent packets. Code is also simpler. > > > > > > Bug: webrtc:13402 chromium:1411666 > > Change-Id: I38c309f74e8e1322602196354545b3a465866263 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/318040 > > Reviewed-by: Björn Terelius <terelius@webrtc.org> > > Commit-Queue: Per Kjellander <perkj@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#40653} > > Bug: webrtc:13402 chromium:1411666 b/298001595 > Change-Id: Ic68ef954f462021e991f3183b94d85eb6a44fac0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/318141 > Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#40658} Bug: webrtc:13402 chromium:1411666 b/298001595 Change-Id: I73f0e9b0e2f209b3833b38241e96ef8f7b3f1e5f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/318282 Commit-Queue: Per Kjellander <perkj@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40664}
This commit is contained in:
Родитель
870c115981
Коммит
25e6c46a06
|
@ -25698,3 +25698,6 @@ d23d450a50
|
|||
# MOZ_LIBWEBRTC_SRC=/home/bcampen/checkouts/elm/.moz-fast-forward/moz-libwebrtc MOZ_LIBWEBRTC_BRANCH=mozpatches bash dom/media/webrtc/third_party_build/fast-forward-libwebrtc.sh
|
||||
# base of lastest vendoring
|
||||
675ef918a8
|
||||
# MOZ_LIBWEBRTC_SRC=/home/bcampen/checkouts/elm/.moz-fast-forward/moz-libwebrtc MOZ_LIBWEBRTC_BRANCH=mozpatches bash dom/media/webrtc/third_party_build/fast-forward-libwebrtc.sh
|
||||
# base of lastest vendoring
|
||||
0fa90c3878
|
||||
|
|
|
@ -17156,3 +17156,5 @@ libwebrtc updated from /home/bcampen/checkouts/elm/.moz-fast-forward/moz-libwebr
|
|||
libwebrtc updated from /home/bcampen/checkouts/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2023-10-27T20:24:38.532274.
|
||||
# ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /home/bcampen/checkouts/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc
|
||||
libwebrtc updated from /home/bcampen/checkouts/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2023-10-27T20:25:53.704517.
|
||||
# ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /home/bcampen/checkouts/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc
|
||||
libwebrtc updated from /home/bcampen/checkouts/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2023-10-27T20:26:42.345111.
|
||||
|
|
|
@ -33,7 +33,9 @@ struct RobustThroughputEstimatorSettings {
|
|||
explicit RobustThroughputEstimatorSettings(
|
||||
const FieldTrialsView* key_value_config);
|
||||
|
||||
bool enabled = false; // Set to true to use RobustThroughputEstimator.
|
||||
// Set `enabled` to true to use the RobustThroughputEstimator, false to use
|
||||
// the AcknowledgedBitrateEstimator.
|
||||
bool enabled = true;
|
||||
|
||||
// The estimator keeps the smallest window containing at least
|
||||
// `window_packets` and at least the packets received during the last
|
||||
|
|
|
@ -63,6 +63,19 @@ class FeedbackGenerator {
|
|||
uint16_t sequence_number_ = 100;
|
||||
};
|
||||
|
||||
TEST(RobustThroughputEstimatorTest, DefaultEnabled) {
|
||||
RobustThroughputEstimatorSettings settings =
|
||||
CreateRobustThroughputEstimatorSettings("");
|
||||
EXPECT_TRUE(settings.enabled);
|
||||
}
|
||||
|
||||
TEST(RobustThroughputEstimatorTest, CanDisable) {
|
||||
RobustThroughputEstimatorSettings settings =
|
||||
CreateRobustThroughputEstimatorSettings(
|
||||
"WebRTC-Bwe-RobustThroughputEstimatorSettings/enabled:false/");
|
||||
EXPECT_FALSE(settings.enabled);
|
||||
}
|
||||
|
||||
TEST(RobustThroughputEstimatorTest, InitialEstimate) {
|
||||
FeedbackGenerator feedback_generator;
|
||||
RobustThroughputEstimator throughput_estimator(
|
||||
|
|
Загрузка…
Ссылка в новой задаче