Bug 360578 add-on dialog buttons not spoken by Orcapatch by tiger.zhang r=aaronleventhalalso contains a fix for compiler warning

accessible/src/xul/nsXULSelectAccessible.cpp

@@ -218,6 +218,14 @@ NS_IMETHODIMP nsXULListitemAccessible::GetActionName(PRUint8 aIndex, nsAString&
   return NS_ERROR_INVALID_ARG;
 }
 
+NS_IMETHODIMP
+nsXULListitemAccessible::GetAllowsAnonChildAccessibles(PRBool *aAllowsAnonChildren)
+{
+  // That indicates we should walk anonymous children for listitems
+  *aAllowsAnonChildren = PR_TRUE;
+  return NS_OK;
+}
+
 /** ------------------------------------------------------ */
 /**  Finally, the Combobox widgets                         */
 /** ------------------------------------------------------ */
@@ -244,10 +252,12 @@ NS_IMETHODIMP nsXULComboboxAccessible::GetRole(PRUint32 *aRole)
   if (!content) {
     return NS_ERROR_FAILURE;
   }
-  *aRole = content->AttrValueIs(kNameSpaceID_None, nsAccessibilityAtoms::type,
-                                NS_LITERAL_STRING("autocomplete"), eIgnoreCase) ?
-                                nsIAccessibleRole::ROLE_AUTOCOMPLETE :
-                                nsIAccessibleRole::ROLE_COMBOBOX;
+  if (content->AttrValueIs(kNameSpaceID_None, nsAccessibilityAtoms::type,
+                           NS_LITERAL_STRING("autocomplete"), eIgnoreCase)) {
+    *aRole = nsIAccessibleRole::ROLE_AUTOCOMPLETE;
+  } else {
+    *aRole = nsIAccessibleRole::ROLE_COMBOBOX;
+  }
   return NS_OK;
 }
 

accessible/src/xul/nsXULSelectAccessible.h

@@ -98,6 +98,7 @@ public:
   NS_IMETHOD GetActionName(PRUint8 index, nsAString& aName);
   // Don't use XUL menuitems's description attribute
   NS_IMETHOD GetDescription(nsAString& aDesc) { return nsAccessibleWrap::GetDescription(aDesc); }
+  NS_IMETHOD GetAllowsAnonChildAccessibles(PRBool *aAllowsAnonChildren);
 
 private:
   PRBool mIsCheckbox;