Bug 1444426 - Remove the 'Automatically update search engines' option from preferences as it is confusing and doesn't fully apply now. r=mikedeboer,fluent-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D55859

--HG--
extra : moz-landing-system : lando

browser/components/preferences/in-content/main.inc.xhtml

@@ -554,9 +554,6 @@
             preference="app.update.service.enabled"/>
 #endif
 #endif
-  <checkbox id="enableSearchUpdate"
-            data-l10n-id="update-enable-search-update"
-            preference="browser.search.update"/>
 </groupbox>
 
 <hbox id="performanceCategory"

browser/components/preferences/in-content/tests/browser_advanced_update.js

@@ -77,10 +77,6 @@ const mockUpdateManager = {
   ],
 };
 
-function resetPreferences() {
-  Services.prefs.clearUserPref("browser.search.update");
-}
-
 function formatInstallDate(sec) {
   var date = new Date(sec);
   const dtOptions = {
@@ -94,28 +90,6 @@ function formatInstallDate(sec) {
   return date.toLocaleString(undefined, dtOptions);
 }
 
-registerCleanupFunction(resetPreferences);
-
-add_task(async function() {
-  await openPreferencesViaOpenPreferencesAPI("general", { leaveOpen: true });
-  resetPreferences();
-  Services.prefs.setBoolPref("browser.search.update", false);
-
-  let doc = gBrowser.selectedBrowser.contentDocument;
-  let enableSearchUpdate = doc.getElementById("enableSearchUpdate");
-  is_element_visible(
-    enableSearchUpdate,
-    "Check search update preference is visible"
-  );
-
-  // Ensure that the update pref dialog reflects the actual pref value.
-  ok(!enableSearchUpdate.checked, "Ensure search updates are disabled");
-  Services.prefs.setBoolPref("browser.search.update", true);
-  ok(enableSearchUpdate.checked, "Ensure search updates are enabled");
-
-  gBrowser.removeCurrentTab();
-});
-
 add_task(async function() {
   await openPreferencesViaOpenPreferencesAPI("general", { leaveOpen: true });
   let doc = gBrowser.selectedBrowser.contentDocument;

browser/locales/en-US/browser/preferences/preferences.ftl

@@ -429,10 +429,6 @@ update-application-use-service =
     .label = Use a background service to install updates
     .accesskey = b
 
-update-enable-search-update =
-    .label = Automatically update search engines
-    .accesskey = e
-
 update-setting-write-failure-title = Error saving Update preferences
 
 # Variables: