Bug 609700 - Shift-clicking the back button or middle-clicking it with browser.tabs.opentabfor.middleclick=false opens an invisible tab. r=gavin

2010-11-10 09:38:08 +01:00 · 2010-11-10 09:38:08 +01:00 · 2845ff9503
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@ -1919,15 +1919,11 @@
        <parameter name="aTab"/>
        <body>
          <![CDATA[
-            if (this.visibleTabs.length == 1)
+            if (this.tabs.length == 1)
              return null;

            // tell a new window to take the "dropped" tab
-            return Services.ww.openWindow(window,
-                                          getBrowserURL(),
-                                          null,
-                                          "chrome,dialog=no,all",
-                                          aTab);
+            return window.openDialog(getBrowserURL(), "_blank", "dialog=no,all", aTab);
          ]]>
        </body>
      </method>
--- a/browser/base/content/test/Makefile.in
+++ b/browser/base/content/test/Makefile.in
@ -160,6 +160,7 @@ _BROWSER_FILES = \
                 browser_bug595507.js \
                 browser_bug596687.js \
                 browser_bug597218.js \
+                 browser_bug609700.js \
                 browser_contextSearchTabPosition.js \
                 browser_ctrlTab.js \
                 browser_discovery.js \
--- a/browser/base/content/test/browser_bug609700.js
+++ b/browser/base/content/test/browser_bug609700.js
@ -0,0 +1,20 @@
+function test() {
+  waitForExplicitFinish();
+
+  Services.ww.registerNotification(function (aSubject, aTopic, aData) {
+    if (aTopic == "domwindowopened") {
+      Services.ww.unregisterNotification(arguments.callee);
+
+      ok(true, "duplicateTabIn opened a new window");
+
+      aSubject.addEventListener("load", function () {
+        executeSoon(function () {
+          aSubject.close();
+          finish();
+        });
+      }, false);
+    }
+  });
+
+  duplicateTabIn(gBrowser.selectedTab, "window");
+}