From 28890c828ca6ed91a2925e3d49fb20420b8e9101 Mon Sep 17 00:00:00 2001 From: Bob Clary Date: Sat, 10 Nov 2018 03:10:08 -0800 Subject: [PATCH] Bug 1501802 - Update tooltool.py fetch_file to log.info exceptions instead of log.debug, r=garbas --HG-- extra : rebase_source : 3268310f08f1911273ab8bff9f8db465ad75e32c extra : intermediate-source : 565215cf2e5e42034860257f4ea4b5d0b0adf75d extra : source : 4034fbcc0a551d86deb3463115c0cf7f8c228b65 --- python/mozbuild/mozbuild/action/tooltool.py | 5 ++--- testing/mozharness/external_tools/tooltool.py | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/python/mozbuild/mozbuild/action/tooltool.py b/python/mozbuild/mozbuild/action/tooltool.py index 3c68326107bd..5d5d02f9cf26 100755 --- a/python/mozbuild/mozbuild/action/tooltool.py +++ b/python/mozbuild/mozbuild/action/tooltool.py @@ -494,10 +494,9 @@ def fetch_file(base_urls, file_record, grabchunk=1024 * 4, auth_file=None, regio (file_record.filename, base_url, temp_path)) fetched_path = temp_path break - except (urllib2.URLError, urllib2.HTTPError, ValueError) as e: + except (urllib2.URLError, urllib2.HTTPError, ValueError): log.info("...failed to fetch '%s' from %s" % - (file_record.filename, base_url)) - log.debug("%s" % e) + (file_record.filename, base_url), exc_info=True) except IOError: # pragma: no cover log.info("failed to write to temporary file for '%s'" % file_record.filename, exc_info=True) diff --git a/testing/mozharness/external_tools/tooltool.py b/testing/mozharness/external_tools/tooltool.py index ac7da8503425..0112921eb611 100755 --- a/testing/mozharness/external_tools/tooltool.py +++ b/testing/mozharness/external_tools/tooltool.py @@ -492,10 +492,9 @@ def fetch_file(base_urls, file_record, grabchunk=1024 * 4, auth_file=None, regio (file_record.filename, base_url, temp_path)) fetched_path = temp_path break - except (urllib2.URLError, urllib2.HTTPError, ValueError) as e: + except (urllib2.URLError, urllib2.HTTPError, ValueError): log.info("...failed to fetch '%s' from %s" % - (file_record.filename, base_url)) - log.debug("%s" % e) + (file_record.filename, base_url), exc_info=True) except IOError: # pragma: no cover log.info("failed to write to temporary file for '%s'" % file_record.filename, exc_info=True)