From 28dcc72e463b4aa6bfdfde6b0f358d67bc727b1d Mon Sep 17 00:00:00 2001 From: "scc%mozilla.org" Date: Thu, 3 May 2001 10:13:59 +0000 Subject: [PATCH] bug #75504; sr=jband. simple fixes correcting where people inappropriately applied |getter_AddRefs|, in this case fixing the leak applying brendan's suggestion --- xpfe/components/xfer/src/nsStreamTransfer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xpfe/components/xfer/src/nsStreamTransfer.cpp b/xpfe/components/xfer/src/nsStreamTransfer.cpp index f2e48ee9a18e..366fc1bf4635 100644 --- a/xpfe/components/xfer/src/nsStreamTransfer.cpp +++ b/xpfe/components/xfer/src/nsStreamTransfer.cpp @@ -239,10 +239,10 @@ nsStreamTransfer::SelectFile( nsIDOMWindowInternal *parent, nsILocalFile **aResu nsCID cid = NS_STRINGBUNDLESERVICE_CID; NS_WITH_SERVICE( nsIStringBundleService, bundleService, cid, &rv ); if ( NS_SUCCEEDED( rv ) ) { - nsIStringBundle *bundle; + nsCOMPtr bundle; PRUnichar *pString; rv = bundleService->CreateBundle( "chrome://global/locale/downloadProgress.properties", - getter_AddRefs( &bundle ) ); + getter_AddRefs(bundle) ); if ( NS_SUCCEEDED( rv ) ) { rv = bundle->GetStringFromName( NS_ConvertASCIItoUCS2( "FilePickerTitle" ).GetUnicode(), &pString ); @@ -267,7 +267,7 @@ nsStreamTransfer::SelectFile( nsIDOMWindowInternal *parent, nsILocalFile **aResu if ( rc != nsIFilePicker::returnCancel ) { // Give result to caller. - rv = picker->GetFile( getter_AddRefs( aResult ) ); + rv = picker->GetFile( aResult ); if ( NS_SUCCEEDED( rv ) && prefs ) { // Save selected directory for next time.