Bug 1362148 - Don't collect package metrics for some Android builds; r=ted

We're about to enable metrics collection for all builds. There are some
Android build configurations that use buildbase.py but don't create a
package. So we need a way to conditionally obtain package metrics.

We could change package metrics collection to no-op if a package file
can't be found. However, that has a risk that a future change could
break metrics collection and we wouldn't necessarily find out. I like
things that fail fast.

MozReview-Commit-ID: CzByf7yHVS8

--HG--
extra : rebase_source : 99ee18ed4dd61e5ea8f5eda1b810b573fe254158

testing/mozharness/configs/builds/releng_sub_android_configs/64_checkstyle.py

@@ -5,6 +5,8 @@ config = {
     'src_mozconfig': 'mobile/android/config/mozconfigs/android-api-15-frontend/nightly',
     'tooltool_manifest_src': 'mobile/android/config/tooltool-manifests/android-frontend/releng.manifest',
     'multi_locale_config_platform': 'android',
+    # checkstyle doesn't produce a package. So don't collect package metrics.
+    'disable_package_metrics': True,
     'postflight_build_mach_commands': [
         ['gradle', 'app:checkstyle'],
     ],

testing/mozharness/configs/builds/releng_sub_android_configs/64_findbugs.py

@@ -5,6 +5,8 @@ config = {
     'src_mozconfig': 'mobile/android/config/mozconfigs/android-api-15-frontend/nightly',
     'tooltool_manifest_src': 'mobile/android/config/tooltool-manifests/android-frontend/releng.manifest',
     'multi_locale_config_platform': 'android',
+    # findbugs doesn't produce a package. So don't collect package metrics.
+    'disable_package_metrics': True,
     'postflight_build_mach_commands': [
         ['gradle',
          'app:findbugsOfficialAustralisDebug',

testing/mozharness/configs/builds/releng_sub_android_configs/64_lint.py

@@ -5,6 +5,8 @@ config = {
     'src_mozconfig': 'mobile/android/config/mozconfigs/android-api-15-frontend/nightly',
     'tooltool_manifest_src': 'mobile/android/config/tooltool-manifests/android-frontend/releng.manifest',
     'multi_locale_config_platform': 'android',
+    # lint doesn't produce a package. So don't collect package metrics.
+    'disable_package_metrics': True,
     'postflight_build_mach_commands': [
         ['gradle',
          'app:lintOfficialAustralisDebug',

testing/mozharness/configs/builds/releng_sub_android_configs/64_test.py

@@ -5,6 +5,8 @@ config = {
     'src_mozconfig': 'mobile/android/config/mozconfigs/android-api-15-frontend/nightly',
     'tooltool_manifest_src': 'mobile/android/config/tooltool-manifests/android-frontend/releng.manifest',
     'multi_locale_config_platform': 'android',
+    # unit tests don't produce a package. So don't collect package metrics.
+    'disable_package_metrics': True,
     'postflight_build_mach_commands': [
         ['gradle',
          'app:testOfficialAustralisDebugUnitTest',

testing/mozharness/mozharness/mozilla/building/buildbase.py

@@ -2030,7 +2030,7 @@ or run without that action (ie: --no-{action})"
             "suites": [],
         }
 
-        if not c.get('debug_build'):
+        if not c.get('debug_build') or c.get('disable_package_metrics'):
             perfherder_data['suites'].extend(self._get_package_metrics())
 
         # Extract compiler warnings count.