From 2917e0f13b578f0c668303e8dae616ab1eaad0bf Mon Sep 17 00:00:00 2001 From: Agi Sferro Date: Fri, 27 Mar 2020 22:03:47 +0000 Subject: [PATCH] Bug 1624675 - Remove dead code from ThreadUtils.java. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D68436 --HG-- extra : moz-landing-system : lando --- .../org/mozilla/gecko/util/ThreadUtils.java | 108 +----------------- 1 file changed, 1 insertion(+), 107 deletions(-) diff --git a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/ThreadUtils.java b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/ThreadUtils.java index 8e3131c230e8..829de8872f7c 100644 --- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/ThreadUtils.java +++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/ThreadUtils.java @@ -7,8 +7,6 @@ package org.mozilla.gecko.util; import org.mozilla.gecko.annotation.RobocopTarget; -import java.util.Map; - import android.os.Handler; import android.os.Looper; import android.util.Log; @@ -20,7 +18,7 @@ public final class ThreadUtils { * Controls the action taken when a method like * {@link ThreadUtils#assertOnUiThread(AssertBehavior)} detects a problem. */ - public static enum AssertBehavior { + public enum AssertBehavior { NONE, THROW, } @@ -37,47 +35,6 @@ public final class ThreadUtils { public static Handler sGeckoHandler; public static volatile Thread sGeckoThread; - // Delayed Runnable that resets the Gecko thread priority. - private static final Runnable sPriorityResetRunnable = new Runnable() { - @Override - public void run() { - resetGeckoPriority(); - } - }; - - private static boolean sIsGeckoPriorityReduced; - - @SuppressWarnings("serial") - public static class UiThreadBlockedException extends RuntimeException { - public UiThreadBlockedException() { - super(); - } - - public UiThreadBlockedException(final String msg) { - super(msg); - } - - public UiThreadBlockedException(final String msg, final Throwable e) { - super(msg, e); - } - - public UiThreadBlockedException(final Throwable e) { - super(e); - } - } - - public static void dumpAllStackTraces() { - Log.w(LOGTAG, "Dumping ALL the threads!"); - Map allStacks = Thread.getAllStackTraces(); - for (Thread t : allStacks.keySet()) { - Log.w(LOGTAG, t.toString()); - for (StackTraceElement ste : allStacks.get(t)) { - Log.w(LOGTAG, ste.toString()); - } - Log.w(LOGTAG, "----"); - } - } - public static void setBackgroundThread(final Thread thread) { sBackgroundThread = thread; } @@ -110,14 +67,6 @@ public final class ThreadUtils { sUiHandler.post(runnable); } - public static void postDelayedToUiThread(final Runnable runnable, final long timeout) { - sUiHandler.postDelayed(runnable, timeout); - } - - public static void removeCallbacksFromUiThread(final Runnable runnable) { - sUiHandler.removeCallbacks(runnable); - } - public static Thread getBackgroundThread() { return sBackgroundThread; } @@ -130,10 +79,6 @@ public final class ThreadUtils { GeckoBackgroundThread.post(runnable); } - public static void postDelayedToBackgroundThread(final Runnable runnable, final long timeout) { - GeckoBackgroundThread.postDelayed(runnable, timeout); - } - public static void assertOnUiThread(final AssertBehavior assertBehavior) { assertOnThread(getUiThread(), assertBehavior); } @@ -151,22 +96,6 @@ public final class ThreadUtils { assertOnThread(sGeckoThread, AssertBehavior.THROW); } - public static void assertNotOnGeckoThread() { - if (sGeckoThread == null) { - // Cannot be on Gecko thread if Gecko thread is not live yet. - return; - } - assertNotOnThread(sGeckoThread, AssertBehavior.THROW); - } - - public static void assertOnBackgroundThread() { - assertOnThread(getBackgroundThread(), AssertBehavior.THROW); - } - - public static void assertOnThread(final Thread expectedThread) { - assertOnThread(expectedThread, AssertBehavior.THROW); - } - public static void assertOnThread(final Thread expectedThread, final AssertBehavior behavior) { assertOnThreadComparison(expectedThread, behavior, true); } @@ -231,39 +160,4 @@ public final class ThreadUtils { public static boolean isOnThread(final Thread thread) { return (Thread.currentThread().getId() == thread.getId()); } - - /** - * Reduces the priority of the Gecko thread, allowing other operations - * (such as those related to the UI and database) to take precedence. - * - * Note that there are no guards in place to prevent multiple calls - * to this method from conflicting with each other. - * - * @param timeout Timeout in ms after which the priority will be reset - */ - public static void reduceGeckoPriority(final long timeout) { - if (Runtime.getRuntime().availableProcessors() > 1) { - // Don't reduce priority for multicore devices. We use availableProcessors() - // for its fast performance. It may give false negatives (i.e. multicore - // detected as single-core), but we can tolerate this behavior. - return; - } - if (!sIsGeckoPriorityReduced && sGeckoThread != null) { - sIsGeckoPriorityReduced = true; - sGeckoThread.setPriority(Thread.MIN_PRIORITY); - getUiHandler().postDelayed(sPriorityResetRunnable, timeout); - } - } - - /** - * Resets the priority of a thread whose priority has been reduced - * by reduceGeckoPriority. - */ - public static void resetGeckoPriority() { - if (sIsGeckoPriorityReduced) { - sIsGeckoPriorityReduced = false; - sGeckoThread.setPriority(Thread.NORM_PRIORITY); - getUiHandler().removeCallbacks(sPriorityResetRunnable); - } - } }