From 299faa2eff20d8ecbcb325f297eeed0e72710d82 Mon Sep 17 00:00:00 2001 From: Markus Stange Date: Tue, 25 Sep 2018 09:16:32 +0000 Subject: [PATCH] Bug 1493261 - Back out Bug 1493261 because it broke symbolication on non-Windows platforms. r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D6572 --HG-- extra : moz-landing-system : lando --- testing/talos/talos/gecko_profile.py | 3 +-- testing/talos/talos/profiler/symbolication.py | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/testing/talos/talos/gecko_profile.py b/testing/talos/talos/gecko_profile.py index 67a856dc5589..7e99019e6e63 100644 --- a/testing/talos/talos/gecko_profile.py +++ b/testing/talos/talos/gecko_profile.py @@ -140,8 +140,7 @@ class GeckoProfile(object): # mapping of app or platform names to directories # Note: App & OS names from requests are converted # to all-uppercase internally - "symbolPaths": self.symbol_paths, - "platformsRequiringSymbols": ["Windows", "Microsoft"] + "symbolPaths": self.symbol_paths }) if self.browser_config['symbols_path']: diff --git a/testing/talos/talos/profiler/symbolication.py b/testing/talos/talos/profiler/symbolication.py index 79a96a8820f9..5b5a7b467352 100755 --- a/testing/talos/talos/profiler/symbolication.py +++ b/testing/talos/talos/profiler/symbolication.py @@ -139,10 +139,8 @@ class ProfileSymbolicator: return None def integrate_symbol_zip_from_url(self, symbol_zip_url): - if platform.system() not in self.options['platformsRequiringSymbols']\ - or self.have_integrated(symbol_zip_url): + if self.have_integrated(symbol_zip_url): return - LogMessage("Retrieving symbol zip from {symbol_zip_url}...".format( symbol_zip_url=symbol_zip_url)) try: