Bug 1387002 - Replace .size() by .empty() when applicable in profiler/ r=njn

MozReview-Commit-ID: 275AVJyhejr

--HG--
extra : rebase_source : b7281214b30b44d51f2d7869b4faf590f3a41ed5

tools/profiler/core/platform.cpp

@@ -195,12 +195,12 @@ private:
 
   ~CorePS()
   {
-    while (mLiveThreads.size() > 0) {
+    while (!mLiveThreads.empty()) {
       delete mLiveThreads.back();
       mLiveThreads.pop_back();
     }
 
-    while (mDeadThreads.size() > 0) {
+    while (!mDeadThreads.empty()) {
       delete mDeadThreads.back();
       mDeadThreads.pop_back();
     }
@@ -2846,7 +2846,7 @@ locked_profiler_stop(PSLockRef aLock)
 
   // This is where we destroy the ThreadInfos for all dead threads.
   CorePS::ThreadVector& deadThreads = CorePS::DeadThreads(aLock);
-  while (deadThreads.size() > 0) {
+  while (!deadThreads.empty()) {
     delete deadThreads.back();
     deadThreads.pop_back();
   }

tools/profiler/core/shared-libraries-linux.cc

@@ -197,7 +197,7 @@ SharedLibraryInfo SharedLibraryInfo::GetInfoForSelf()
   // executable's name to that entry.
   for (size_t i = 0; i < info.GetSize(); i++) {
     SharedLibrary& lib = info.GetMutableEntry(i);
-    if (lib.GetStart() == exeExeAddr && lib.GetNativeDebugPath() == "") {
+    if (lib.GetStart() == exeExeAddr && lib.GetNativeDebugPath().empty()) {
       lib = SharedLibraryAtPath(exeName, lib.GetStart(), lib.GetEnd(),
                                 lib.GetOffset());