Bug 1027251 - Address review comments on mtransport - r=abr

(Sorry about that!)

media/mtransport/databuffer.h

@@ -17,6 +17,8 @@ namespace mozilla {
 
 class DataBuffer;
 
+// Temporary whitelist for refcounted class dangerously exposing its destructor.
+// Filed bug 1028139 to address this class.
 template<>
 struct HasDangerousPublicDestructor<DataBuffer>
 {

media/mtransport/dtlsidentity.h

@@ -19,6 +19,7 @@
 namespace mozilla {
 
 class DtlsIdentity {
+ private:
   ~DtlsIdentity();
 
  public:

media/mtransport/nriceresolver.h

@@ -61,6 +61,7 @@ namespace mozilla {
 
 class NrIceResolver
 {
+ private:
   ~NrIceResolver();
  public:
   NrIceResolver();

media/mtransport/test/buffered_stun_socket_unittest.cpp

@@ -44,6 +44,8 @@ static size_t kStunMessageLen = sizeof(kStunMessage);
 
 class DummySocket;
 
+// Temporary whitelist for refcounted class dangerously exposing its destructor.
+// Filed bug 1028140 to address this class.
 namespace mozilla {
 template<>
 struct HasDangerousPublicDestructor<DummySocket>

media/mtransport/test/runnable_utils_unittest.cpp

@@ -38,6 +38,7 @@ MtransportTestUtils *test_utils;
 namespace {
 
 class Destructor {
+ private:
   ~Destructor() {
     std::cerr << "Destructor called" << std::endl;
     *destroyed_ = true;