Bug 1395841 - Part 2: Support creating a shortcut from page option in menu. r=nechen

When page option 'add page shortcut' is clicked, creating a shortcut(not PWA) on launcher.
Also make sure that heavy tasks are executed in background thread.

MozReview-Commit-ID: 8KtwdXENtEd

--HG--
extra : rebase_source : 12a427f549a41f9d8650b4b8d95394bdc4192c4b

mobile/android/base/java/org/mozilla/gecko/BrowserApp.java

@@ -1506,7 +1506,7 @@ public class BrowserApp extends GeckoApp
             ThreadUtils.postToBackgroundThread(new Runnable() {
                 @Override
                 public void run() {
-                    GeckoApplication.createShortcut(title, url);
+                    GeckoApplication.createBrowserShortcut(title, url);
                 }
             });
 

mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java

@@ -52,6 +52,7 @@ import org.mozilla.gecko.util.GeckoBundle;
 import org.mozilla.gecko.util.HardwareUtils;
 import org.mozilla.gecko.util.PRNGFixes;
 import org.mozilla.gecko.util.ThreadUtils;
+import org.mozilla.gecko.util.UIAsyncTask;
 
 import java.io.File;
 import java.lang.reflect.Method;
@@ -570,12 +571,21 @@ public class GeckoApplication extends Application
         intent.setAction("com.android.launcher.action.INSTALL_SHORTCUT");
         context.sendBroadcast(intent);
 
-        // Remember interaction
-        final UrlAnnotations urlAnnotations = BrowserDB.from(context).getUrlAnnotations();
-        urlAnnotations.insertHomeScreenShortcut(context.getContentResolver(), aURI, true);
+        (new UIAsyncTask.WithoutParams<Void>(ThreadUtils.getBackgroundHandler()) {
+            @Override
+            public Void doInBackground() {
+                // Remember interaction, post to background thread to prevent violating StrictMode policy.
+                final UrlAnnotations urlAnnotations = BrowserDB.from(context).getUrlAnnotations();
+                urlAnnotations.insertHomeScreenShortcut(context.getContentResolver(), aURI, true);
+                return null;
+            }
 
-        // After shortcut is created, show the mobile desktop.
-        ActivityUtils.goToHomeScreen(context);
+            @Override
+            public void onPostExecute(Void aVoid) {
+                // After shortcut is created and db entry is inserted, show the mobile desktop.
+                ActivityUtils.goToHomeScreen(context);
+            }
+        }).execute();
     }
 
     private static Bitmap getLauncherIcon(Bitmap aSource, int size) {

mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/menu/ActivityStreamContextMenu.java

@@ -284,7 +284,12 @@ public abstract class ActivityStreamContextMenu
                 break;
 
             case R.id.add_homescreen:
-                GeckoApplication.createShortcut(item.getTitle(), item.getUrl());
+                ThreadUtils.postToBackgroundThread(new Runnable() {
+                    @Override
+                    public void run() {
+                        GeckoApplication.createBrowserShortcut(item.getTitle(), item.getUrl());
+                    }
+                });
                 break;
 
             case R.id.open_new_tab:

mobile/android/base/java/org/mozilla/gecko/delegates/BookmarkStateChangeDelegate.java

@@ -185,7 +185,7 @@ public class BookmarkStateChangeDelegate extends BrowserAppDelegateWithReference
                         ThreadUtils.postToBackgroundThread(new Runnable() {
                             @Override
                             public void run() {
-                                GeckoApplication.createShortcut(title, url);
+                                GeckoApplication.createBrowserShortcut(title, url);
                             }
                         });
                     }

mobile/android/base/java/org/mozilla/gecko/home/HomeFragment.java

@@ -312,8 +312,7 @@ public abstract class HomeFragment extends Fragment {
             ThreadUtils.postToBackgroundThread(new Runnable() {
                 @Override
                 public void run() {
-                    GeckoApplication.createShortcut(displayTitle, info.url);
-
+                    GeckoApplication.createBrowserShortcut(displayTitle, info.url);
                 }
             });
 

mobile/android/base/java/org/mozilla/gecko/promotion/HomeScreenPrompt.java

@@ -120,7 +120,7 @@ public class HomeScreenPrompt extends Locales.LocaleAwareActivity implements Ico
         ThreadUtils.postToBackgroundThread(new Runnable() {
             @Override
             public void run() {
-                GeckoApplication.createShortcut(title, url);
+                GeckoApplication.createBrowserShortcut(title, url);
 
                 Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.BUTTON, TELEMETRY_EXTRA);
 
@@ -131,8 +131,6 @@ public class HomeScreenPrompt extends Locales.LocaleAwareActivity implements Ico
         });
     }
 
-
-
     private void loadShortcutIcon() {
         Icons.with(this)
                 .pageUrl(url)