Backed out changeset 5561bb7124db

xpcom/base/nsMemoryReporterManager.cpp

@@ -308,14 +308,16 @@ NS_MEMORY_REPORTER_IMPLEMENT(HeapCommitted,
     KIND_OTHER,
     UNITS_BYTES,
     GetHeapCommitted,
-    "This number reported only for completeness; it is not particularly "
+    "Memory mapped by the heap allocator that is committed, i.e. in physical "
-    "meaningful. On Windows, all mapped memory is committed (because jemalloc's "
+    "memory or paged to disk.  The allocator may map blocks of many pages and "
-    "MALLOC_DECOMMIT flag is set). Thus heap-committed should equal "
+    "then hand out only some of those pages in response to a call to malloc. "
-    "heap-allocated + heap-unallocated. Elsewhere, jemalloc uses "
+    "Only those pages which have been handed out to the application are counted "
-    "madvise(DONT_NEED) to instruct the OS to drop the physical memory backing "
+    "as committed -- the OS lazily assigns physical pages to mappings, so those "
-    "pages the allocator doesn't need.  In this case, jemalloc counts the memory "
+    "pages which the allocator has not handed out haven't been written to and "
-    "as 'committed', but it's not taking up any space in physical memory or in "
+    "therefore don't have a corresponding physical page.  (Of course, the "
-    "the swap file.");
+    "application may malloc pages and free them without ever writing to the "
+    "pages and causing them to be committed.  But the allocator conservatively "
+    "assumes that the application writes to all pages it receives.)")
 
 NS_MEMORY_REPORTER_IMPLEMENT(HeapDirty,
     "heap-dirty",