Bug 1651731: [lint] Add a bunch more types of files that should never be executable; r=linter-reviewers,perftest-reviewers,geckoview-reviewers,preferences-reviewers,agi,sylvestre,sparky

Differential Revision: https://phabricator.services.mozilla.com/D82953
2020-07-09 21:28:49 +00:00 · 2020-07-09 21:28:49 +00:00 · 2c52622b85
--- a/browser/components/newtab/data/content/assets/trailhead/benefit-knowledge.png
+++ b/browser/components/newtab/data/content/assets/trailhead/benefit-knowledge.png
--- a/browser/components/newtab/data/content/assets/trailhead/benefit-privacy.png
+++ b/browser/components/newtab/data/content/assets/trailhead/benefit-privacy.png
--- a/browser/components/newtab/data/content/assets/trailhead/benefit-products.png
+++ b/browser/components/newtab/data/content/assets/trailhead/benefit-products.png
--- a/browser/components/newtab/data/content/assets/trailhead/firefox-logo.png
+++ b/browser/components/newtab/data/content/assets/trailhead/firefox-logo.png
--- a/browser/components/pocket/content/panels/img/app_store_dowload_apple.svg
+++ b/browser/components/pocket/content/panels/img/app_store_dowload_apple.svg
--- a/browser/themes/shared/fxa/sync-illustration.svg
+++ b/browser/themes/shared/fxa/sync-illustration.svg
--- a/browser/themes/shared/icons/developer.svg
+++ b/browser/themes/shared/icons/developer.svg
--- a/browser/themes/shared/icons/device-desktop.svg
+++ b/browser/themes/shared/icons/device-desktop.svg
--- a/browser/themes/shared/icons/device-phone.svg
+++ b/browser/themes/shared/icons/device-phone.svg
--- a/browser/themes/shared/icons/edit-copy.svg
+++ b/browser/themes/shared/icons/edit-copy.svg
--- a/browser/themes/shared/icons/edit-cut.svg
+++ b/browser/themes/shared/icons/edit-cut.svg
--- a/browser/themes/shared/icons/edit-paste.svg
+++ b/browser/themes/shared/icons/edit-paste.svg
--- a/browser/themes/shared/icons/forget.svg
+++ b/browser/themes/shared/icons/forget.svg
--- a/browser/themes/shared/icons/fullscreen-exit.svg
+++ b/browser/themes/shared/icons/fullscreen-exit.svg
--- a/browser/themes/shared/icons/history.svg
+++ b/browser/themes/shared/icons/history.svg
--- a/browser/themes/shared/icons/logo-android.svg
+++ b/browser/themes/shared/icons/logo-android.svg
--- a/browser/themes/shared/icons/logo-ios.svg
+++ b/browser/themes/shared/icons/logo-ios.svg
--- a/browser/themes/shared/icons/mail.svg
+++ b/browser/themes/shared/icons/mail.svg
--- a/browser/themes/shared/icons/new-tab.svg
+++ b/browser/themes/shared/icons/new-tab.svg
--- a/browser/themes/shared/icons/new-window.svg
+++ b/browser/themes/shared/icons/new-window.svg
--- a/browser/themes/shared/icons/open.svg
+++ b/browser/themes/shared/icons/open.svg
--- a/browser/themes/shared/icons/print.svg
+++ b/browser/themes/shared/icons/print.svg
--- a/browser/themes/shared/icons/privateBrowsing.svg
+++ b/browser/themes/shared/icons/privateBrowsing.svg
--- a/browser/themes/shared/icons/quit.svg
+++ b/browser/themes/shared/icons/quit.svg
--- a/browser/themes/shared/icons/save.svg
+++ b/browser/themes/shared/icons/save.svg
--- a/browser/themes/shared/icons/stop.svg
+++ b/browser/themes/shared/icons/stop.svg
--- a/browser/themes/shared/icons/sync.svg
+++ b/browser/themes/shared/icons/sync.svg
--- a/browser/themes/shared/icons/tab.svg
+++ b/browser/themes/shared/icons/tab.svg
--- a/browser/themes/shared/preferences/face-sad.svg
+++ b/browser/themes/shared/preferences/face-sad.svg
--- a/browser/themes/shared/preferences/face-smile.svg
+++ b/browser/themes/shared/preferences/face-smile.svg
--- a/browser/themes/shared/tabbrowser/badge-audio-playing.svg
+++ b/browser/themes/shared/tabbrowser/badge-audio-playing.svg
--- a/devtools/client/debugger/packages/devtools-wasm-dwarf/wasm/dwarf_to_json.wasm
+++ b/devtools/client/debugger/packages/devtools-wasm-dwarf/wasm/dwarf_to_json.wasm
--- a/devtools/client/debugger/test/mochitest/examples/wasm-sourcemaps/fib.debug.wasm
+++ b/devtools/client/debugger/test/mochitest/examples/wasm-sourcemaps/fib.debug.wasm
--- a/devtools/client/inspector/fonts/test/ostrich-black.ttf
+++ b/devtools/client/inspector/fonts/test/ostrich-black.ttf
--- a/devtools/client/inspector/fonts/test/ostrich-regular.ttf
+++ b/devtools/client/inspector/fonts/test/ostrich-regular.ttf
--- a/devtools/client/themes/images/item-arrow-rtl.svg
+++ b/devtools/client/themes/images/item-arrow-rtl.svg
--- a/devtools/docs/tests/perfherder-compare-link.png
+++ b/devtools/docs/tests/perfherder-compare-link.png
--- a/devtools/docs/tests/perfherder-compare.png
+++ b/devtools/docs/tests/perfherder-compare.png
--- a/devtools/docs/tests/perfherder-damp.png
+++ b/devtools/docs/tests/perfherder-damp.png
--- a/devtools/docs/tests/perfherder-filter-subtests.png
+++ b/devtools/docs/tests/perfherder-filter-subtests.png
--- a/devtools/docs/tests/perfherder-subtests.png
+++ b/devtools/docs/tests/perfherder-subtests.png
--- a/devtools/docs/tests/regression-graph.png
+++ b/devtools/docs/tests/regression-graph.png
--- a/devtools/docs/tests/regression-popup.png
+++ b/devtools/docs/tests/regression-popup.png
--- a/devtools/startup/aboutdevtools/images/feature-console.svg
+++ b/devtools/startup/aboutdevtools/images/feature-console.svg
--- a/devtools/startup/aboutdevtools/images/feature-debugger.svg
+++ b/devtools/startup/aboutdevtools/images/feature-debugger.svg
--- a/devtools/startup/aboutdevtools/images/feature-inspector.svg
+++ b/devtools/startup/aboutdevtools/images/feature-inspector.svg
--- a/devtools/startup/aboutdevtools/images/feature-memory.svg
+++ b/devtools/startup/aboutdevtools/images/feature-memory.svg
--- a/devtools/startup/aboutdevtools/images/feature-network.svg
+++ b/devtools/startup/aboutdevtools/images/feature-network.svg
--- a/devtools/startup/aboutdevtools/images/feature-performance.svg
+++ b/devtools/startup/aboutdevtools/images/feature-performance.svg
--- a/devtools/startup/aboutdevtools/images/feature-responsive.svg
+++ b/devtools/startup/aboutdevtools/images/feature-responsive.svg
--- a/devtools/startup/aboutdevtools/images/feature-storage.svg
+++ b/devtools/startup/aboutdevtools/images/feature-storage.svg
--- a/devtools/startup/aboutdevtools/images/feature-visualediting.svg
+++ b/devtools/startup/aboutdevtools/images/feature-visualediting.svg
--- a/dom/media/gtest/mp4_demuxer/test_case_1216748.mp4
+++ b/dom/media/gtest/mp4_demuxer/test_case_1216748.mp4
--- a/dom/media/mediasource/test/avc3/init.mp4
+++ b/dom/media/mediasource/test/avc3/init.mp4
--- a/dom/media/mediasource/test/avc3/segment1.m4s
+++ b/dom/media/mediasource/test/avc3/segment1.m4s
--- a/dom/media/mediasource/test/bipbop/bipbop_480_624kbps-video1.m4s
+++ b/dom/media/mediasource/test/bipbop/bipbop_480_624kbps-video1.m4s
--- a/dom/media/mediasource/test/bipbop/bipbop_480_624kbps-video2.m4s
+++ b/dom/media/mediasource/test/bipbop/bipbop_480_624kbps-video2.m4s
--- a/dom/media/mediasource/test/bipbop/bipbop_480_624kbps-videoinit.mp4
+++ b/dom/media/mediasource/test/bipbop/bipbop_480_624kbps-videoinit.mp4
--- a/dom/media/test/flac-noheader-s16.flac
+++ b/dom/media/test/flac-noheader-s16.flac
--- a/gfx/layers/layerviewer/noise.png
+++ b/gfx/layers/layerviewer/noise.png
--- a/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors.png
+++ b/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors.png
--- a/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors_br.png
+++ b/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors_br.png
--- a/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors_br_scaled.png
+++ b/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors_br_scaled.png
--- a/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors_tl.png
+++ b/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors_tl.png
--- a/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors_tl_scaled.png
+++ b/mobile/android/geckoview/src/androidTest/res/drawable-nodpi/colors_tl_scaled.png
--- a/taskcluster/ci/build/windows.yml
+++ b/taskcluster/ci/build/windows.yml
--- a/taskcluster/ci/fetch/toolchains.yml
+++ b/taskcluster/ci/fetch/toolchains.yml
--- a/testing/raptor/raptor/perfdocs/config.yml
+++ b/testing/raptor/raptor/perfdocs/config.yml
--- a/toolkit/themes/shared/icons/arrow-left.svg
+++ b/toolkit/themes/shared/icons/arrow-left.svg
--- a/toolkit/themes/shared/icons/identity-icon.svg
+++ b/toolkit/themes/shared/icons/identity-icon.svg
--- a/tools/lint/file-perm.yml
+++ b/tools/lint/file-perm.yml
@ -7,16 +7,24 @@ file-perm:
        - .c
        - .cc
        - .cpp
+        - .flac
        - .h
        - .html
        - .jsm
        - .jsx
        - .m
+        - .m4s
        - .mm
+        - .mp4
+        - .png
        - .rs
+        - .svg
+        - .ttf
+        - .wasm
        - .xhtml
        - .xml
        - .xul
+        - .yml
    support-files:
        - 'tools/lint/file-perm/**'
    type: external
--- a/tools/lint/test/files/file-perm/no-shebang/bad.png
+++ b/tools/lint/test/files/file-perm/no-shebang/bad.png
--- a/tools/lint/test/test_file_perm.py
+++ b/tools/lint/test/test_file_perm.py
@ -11,11 +11,11 @@ LINTER = "file-perm"
 def test_lint_file_perm(lint, paths):
    results = lint(paths("no-shebang"), collapse_results=True)
    print(results)
-    assert len(results) == 2

    assert results.keys() == {
        "no-shebang/bad.c",
        "no-shebang/bad-shebang.c",
+        "no-shebang/bad.png",
    }

    for path, issues in results.items():