Bug 1858141 - Adapt clipboard suggestions to the spec. r=mak,fluent-reviewers,desktop-theme-reviewers,dao

Differential Revision: https://phabricator.services.mozilla.com/D190846

browser/components/urlbar/UrlbarProviderClipboard.sys.mjs

@@ -105,7 +105,7 @@ class ProviderClipboard extends UrlbarProvider {
       {
         url: this.#previousClipboard.value,
         title: this.#previousClipboard.value,
-        icon: "chrome://global/skin/icons/edit-copy.svg",
+        icon: "chrome://global/skin/icons/clipboard.svg",
       }
     );
 

browser/components/urlbar/UrlbarView.sys.mjs

@@ -1834,7 +1834,7 @@ export class UrlbarView {
           result.payload.displayUrl = "";
           actionSetter = () => {
             this.#setElementL10n(action, {
-              id: "urlbar-result-action-visit-from-your-clipboard",
+              id: "urlbar-result-action-visit-from-clipboard",
             });
           };
           title.toggleAttribute("is-url", true);
@@ -2835,7 +2835,7 @@ export class UrlbarView {
       { id: "urlbar-result-action-search-tabs" },
       { id: "urlbar-result-action-switch-tab" },
       { id: "urlbar-result-action-visit" },
-      { id: "urlbar-result-action-visit-from-your-clipboard" },
+      { id: "urlbar-result-action-visit-from-clipboard" },
     ];
 
     if (lazy.UrlbarPrefs.get("groupLabels.enabled")) {

browser/components/urlbar/tests/browser/browser_clipboard.js

@@ -70,7 +70,7 @@ add_task(async function testUserEngagementWithClipboardSuggestion() {
       );
       Assert.equal(
         result.icon,
-        "chrome://global/skin/icons/edit-copy.svg",
+        "chrome://global/skin/icons/clipboard.svg",
         "Clipboard suggestion icon"
       );
       await checkClipboardSuggestionAbsent(1);

browser/locales/en-US/browser/browser.ftl

@@ -599,7 +599,7 @@ urlbar-result-action-sponsored = Sponsored
 urlbar-result-action-switch-tab = Switch to Tab
 urlbar-result-action-visit = Visit
 # Allows the user to visit a URL that was previously copied to the clipboard.
-urlbar-result-action-visit-from-your-clipboard = Visit from your clipboard
+urlbar-result-action-visit-from-clipboard = Visit from clipboard
 # Directs a user to press the Tab key to perform a search with the specified
 # engine.
 # Variables

browser/themes/shared/urlbarView.css

@@ -641,8 +641,8 @@
   }
 }
 
-/* Switch-to-tab action text is styled as a chiclet. */
-.urlbarView-row:is([type=switchtab], [type=remotetab]) {
+/* Switch-to-tab and Clipboard action text is styled as a chiclet. */
+.urlbarView-row:is([type=switchtab], [type=remotetab], [type=clipboard]) {
   > .urlbarView-row-inner > .urlbarView-no-wrap > .urlbarView-action {
     color: var(--urlbar-box-text-color);
     background-color: var(--urlbar-box-focus-bgcolor);
@@ -663,8 +663,9 @@
   }
 }
 
+.urlbarView:not([action-override]) .urlbarView-row[type=switchtab],
 .urlbarView-row[type=remotetab]:not([selected], :hover),
-.urlbarView:not([action-override]) .urlbarView-row[type=switchtab] {
+.urlbarView-row[type=clipboard] {
   > .urlbarView-row-inner > .urlbarView-no-wrap > .urlbarView-title-separator::before {
     /* We make the title separator transparent so it stays in the accessibility
        tree. We want screen readers to pause between the result title and the

toolkit/themes/shared/desktop-jar.inc.mn

@@ -68,6 +68,7 @@
   skin/classic/global/icons/check-filled.svg               (../../shared/icons/check-filled.svg)
   skin/classic/global/icons/check-partial.svg              (../../shared/icons/check-partial.svg)
   skin/classic/global/icons/chevron.svg                    (../../shared/icons/chevron.svg)
+  skin/classic/global/icons/clipboard.svg                  (../../shared/icons/clipboard.svg)
   skin/classic/global/icons/close.svg                      (../../shared/icons/close.svg)
   skin/classic/global/icons/close-12.svg                   (../../shared/icons/close-12.svg)
   skin/classic/global/icons/close-fill.svg                 (../../shared/icons/close-fill.svg)

toolkit/themes/shared/icons/clipboard.svg

@@ -0,0 +1,7 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/.-->
+<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24">
+  <path fill="context-fill" fill-rule="evenodd" d="M8.75 10.25h6.5V12h-6.5v-1.75ZM8.75 14.25h3.97V16H8.75v-1.75Z"/>
+  <path fill="context-fill" fill-rule="evenodd" d="M17 3h-1.54a4 4 0 0 0-6.92 0H7a2.5 2.5 0 0 0-2.5 2.5v14A2.5 2.5 0 0 0 7 22h10a2.5 2.5 0 0 0 2.5-2.5v-14A2.5 2.5 0 0 0 17 3ZM9.5 8A1.5 1.5 0 0 1 8 6.5V4.75H7a.75.75 0 0 0-.75.75v14c0 .41.34.75.75.75h10c.41 0 .75-.34.75-.75v-14a.75.75 0 0 0-.75-.75h-1V6.5c0 .83-.67 1.5-1.5 1.5h-5ZM11 5.5v-2h2v2h-2Z"/>
+</svg>