From 2c8442f685414f7db0924e9f72d3f8fba0221e39 Mon Sep 17 00:00:00 2001 From: Aleks Totic Date: Thu, 7 Jan 2021 09:54:33 +0000 Subject: [PATCH] Bug 1684984 [wpt PR 27038] - [wpt] Fix position-sticky-nested-table.html, a=testonly Automatic update from web-platform-tests [wpt] Fix position-sticky-nested-table.html wpt/css/css-position/sticky/position-sticky-nested-table.html test was broken. It failed in FF/Safari, and Chrome with TablesNG. https://wpt.fyi/results/css/css-position/sticky/position-sticky-nested-table.html The broken part of the test insterted an absolutely positioned element as a sibling of every element with sticky position. The abspos element is then positioned so that its position matches sticky elements position. I am not sure what this was testing. This does not work for tables, because instertion of abspos sibling to td element creates an anonymous table wrapper. The anonymous wrapper becomes abspos container. This CL removes creation of the abspos element. The test now passes in all browsers. Change-Id: I548afad533040509567ca24265306ace0d28d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610190 Reviewed-by: David Grogan Commit-Queue: Aleks Totic Cr-Commit-Position: refs/heads/master@{#840049} -- wpt-commits: 7bf6d4ccbc72baeb1753e45c38f6e1ee4c520353 wpt-pr: 27038 --- .../css/css-position/sticky/position-sticky-nested-table.html | 1 - 1 file changed, 1 deletion(-) diff --git a/testing/web-platform/tests/css/css-position/sticky/position-sticky-nested-table.html b/testing/web-platform/tests/css/css-position/sticky/position-sticky-nested-table.html index 7a5fca415dce..51ea20588ae1 100644 --- a/testing/web-platform/tests/css/css-position/sticky/position-sticky-nested-table.html +++ b/testing/web-platform/tests/css/css-position/sticky/position-sticky-nested-table.html @@ -64,7 +64,6 @@ window.addEventListener('load', function() { document.getElementById('scroller1').scrollTop = 50; document.getElementById('scroller2').scrollTop = 125; document.getElementById('scroller3').scrollTop = 250; - createIndicatorForStickyElements(document.querySelectorAll('.sticky')); });