Bug 1429603: Remove always false `enable_talos_sendchange`; r=jlund

Differential Revision: https://phabricator.services.mozilla.com/D367

--HG--
extra : rebase_source : 77b53c891c93010884edb592090ca45a58181f33

testing/mozharness/configs/builds/releng_base_android_64_builds.py

@@ -74,7 +74,6 @@ config = {
     'tooltool_script': ["/builds/tooltool.py"],
     'tooltool_bootstrap': "setup.sh",
     'enable_count_ctors': False,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': True,
     'multi_locale': True,
     #########################################################################

testing/mozharness/configs/builds/releng_base_linux_32_builds.py

@@ -58,7 +58,6 @@ config = {
     'tooltool_script': ["/builds/tooltool.py"],
     'tooltool_bootstrap': "setup.sh",
     'enable_count_ctors': True,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': True,
     #########################################################################
 

testing/mozharness/configs/builds/releng_base_linux_64_builds.py

@@ -57,7 +57,6 @@ config = {
     'tooltool_script': ["/builds/tooltool.py"],
     'tooltool_bootstrap': "setup.sh",
     'enable_count_ctors': True,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': True,
     #########################################################################
 

testing/mozharness/configs/builds/releng_base_mac_64_cross_builds.py

@@ -30,7 +30,6 @@ config = {
     'tooltool_script': ["/builds/tooltool.py"],
     'tooltool_bootstrap': "setup.sh",
     'enable_count_ctors': False,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': False,
     #########################################################################
 

testing/mozharness/configs/builds/releng_sub_linux_configs/32_artifact.py

@@ -27,7 +27,6 @@ config = {
     'enable_count_ctors': True,
     # allows triggering of dependent jobs when --artifact try syntax is detected on buildbot
     'enable_unittest_sendchange': True,
-    'enable_talos_sendchange': False,
     'perfherder_extra_options': ['artifact'],
     #########################################################################
 

testing/mozharness/configs/builds/releng_sub_linux_configs/32_debug.py

@@ -15,7 +15,6 @@ config = {
     'debug_build': True,
     'stage_platform': 'linux-debug',
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 32 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/32_debug_artifact.py

@@ -27,7 +27,6 @@ config = {
     'enable_count_ctors': True,
     # debug specific
     'debug_build': True,
-    'enable_talos_sendchange': False,
     # allows triggering of test jobs when --artifact try syntax is detected on buildbot
     'enable_unittest_sendchange': True,
     'perfherder_extra_options': ['artifact'],

testing/mozharness/configs/builds/releng_sub_linux_configs/32_rusttests.py

@@ -13,7 +13,6 @@ config = {
     ],
     'stage_platform': 'linux-rusttests',
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 32 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/32_rusttests_debug.py

@@ -14,7 +14,6 @@ config = {
     'debug_build': True,
     'stage_platform': 'linux-rusttests-debug',
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 32 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_add-on-devel.py

@@ -17,7 +17,6 @@ config = {
     'build_type': 'add-on-devel',
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_artifact.py

@@ -28,7 +28,6 @@ config = {
     'enable_count_ctors': True,
     # allows triggering of dependent jobs when --artifact try syntax is detected on buildbot
     'enable_unittest_sendchange': True,
-    'enable_talos_sendchange': False,
     'perfherder_extra_options': ['artifact'],
     #########################################################################
 

testing/mozharness/configs/builds/releng_sub_linux_configs/64_asan.py

@@ -17,7 +17,6 @@ config = {
     'build_type': 'asan',
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_asan_and_debug.py

@@ -18,7 +18,6 @@ config = {
     'debug_build': True,
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_asan_reporter_tc.py

@@ -17,7 +17,6 @@ config = {
     'build_type': 'asan',
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_asan_tc.py

@@ -17,7 +17,6 @@ config = {
     'build_type': 'asan',
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_asan_tc_and_debug.py

@@ -18,7 +18,6 @@ config = {
     'debug_build': True,
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_code_coverage.py

@@ -15,7 +15,6 @@ config = {
     'stage_platform': 'linux64-ccov',
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     'enable_count_ctors': False,
     #### 64 bit build specific #####
     'env': {

testing/mozharness/configs/builds/releng_sub_linux_configs/64_debug.py

@@ -15,7 +15,6 @@ config = {
     'stage_platform': 'linux64-debug',
     'debug_build': True,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_debug_artifact.py

@@ -20,7 +20,6 @@ config = {
     'debug_build': True,
     # decides whether we want to use moz_sign_cmd in env
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     # allows triggering of test jobs when --artifact try syntax is detected on buildbot
     'enable_unittest_sendchange': True,
     'perfherder_extra_options': ['artifact'],

testing/mozharness/configs/builds/releng_sub_linux_configs/64_fuzzing_asan_tc.py

@@ -17,7 +17,6 @@ config = {
     'build_type': 'asan',
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_fuzzing_debug.py

@@ -16,7 +16,6 @@ config = {
     'debug_build': True,
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_noopt_debug.py

@@ -15,7 +15,6 @@ config = {
     'stage_platform': 'linux64-noopt-debug',
     'debug_build': True,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),
         'DISPLAY': ':2',

testing/mozharness/configs/builds/releng_sub_linux_configs/64_rusttests.py

@@ -14,7 +14,6 @@ config = {
     ],
     'stage_platform': 'linux64-rusttests',
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_linux_configs/64_rusttests_debug.py

@@ -14,7 +14,6 @@ config = {
     'stage_platform': 'linux64-rusttests-debug',
     'debug_build': True,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),
         'DISPLAY': ':2',

testing/mozharness/configs/builds/releng_sub_linux_configs/64_searchfox_and_debug.py

@@ -17,7 +17,6 @@ config = {
     'tooltool_script': ["/builds/tooltool.py"],
     'tooltool_bootstrap': "setup.sh",
     'enable_count_ctors': True,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': False,
     'perfherder_extra_options': ['static-analysis'],
     #########################################################################

testing/mozharness/configs/builds/releng_sub_linux_configs/64_stat_and_debug.py

@@ -17,7 +17,6 @@ config = {
     'tooltool_script': ["/builds/tooltool.py"],
     'tooltool_bootstrap': "setup.sh",
     'enable_count_ctors': True,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': False,
     'perfherder_extra_options': ['static-analysis'],
     #########################################################################

testing/mozharness/configs/builds/releng_sub_linux_configs/64_stat_and_opt.py

@@ -17,7 +17,6 @@ config = {
     'tooltool_script': ["/builds/tooltool.py"],
     'tooltool_bootstrap': "setup.sh",
     'enable_count_ctors': True,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': False,
     'perfherder_extra_options': ['static-analysis'],
     #########################################################################

testing/mozharness/configs/builds/releng_sub_linux_configs/64_valgrind.py

@@ -18,7 +18,6 @@ config = {
     'build_type': 'valgrind',
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     'perfherder_extra_options': ['valgrind'],
     #### 64 bit build specific #####
     'env': {

testing/mozharness/configs/builds/releng_sub_mac_configs/64_add-on-devel.py

@@ -17,7 +17,6 @@ config = {
     'build_type': 'add-on-devel',
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_mac_configs/64_artifact.py

@@ -24,7 +24,6 @@ config = {
     'enable_count_ctors': False,
     # allows triggering of dependent jobs when --artifact try syntax is detected on buildbot
     'enable_unittest_sendchange': False,
-    'enable_talos_sendchange': False,
     'perfherder_extra_options': ['artifact'],
     #########################################################################
 

testing/mozharness/configs/builds/releng_sub_mac_configs/64_cross_debug.py

@@ -13,7 +13,6 @@ config = {
     ],
     'stage_platform': 'macosx64-debug',
     'debug_build': True,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_mac_configs/64_cross_debug_searchfox.py

@@ -13,9 +13,7 @@ config = {
     ],
     'stage_platform': 'macosx64-searchfox-debug',
     'debug_build': True,
-    'enable_talos_sendchange': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': False,
     'perfherder_extra_options': ['static-analysis'],
     #### 64 bit build specific #####

testing/mozharness/configs/builds/releng_sub_mac_configs/64_cross_noopt_debug.py

@@ -13,7 +13,6 @@ config = {
     ],
     'stage_platform': 'macosx64-noopt-debug',
     'debug_build': True,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),

testing/mozharness/configs/builds/releng_sub_mac_configs/64_debug.py

@@ -14,7 +14,6 @@ config = {
     ],
     'stage_platform': 'macosx64-debug',
     'debug_build': True,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': False,
     #### 64 bit build specific #####
     'env': {

testing/mozharness/configs/builds/releng_sub_mac_configs/64_debug_artifact.py

@@ -20,7 +20,6 @@ config = {
     'vcs_share_base': '/builds/hg-shared',
     # debug specific
     'debug_build': True,
-    'enable_talos_sendchange': False,
     # allows triggering of test jobs when --artifact try syntax is detected on buildbot
     'enable_unittest_sendchange': True,
     'perfherder_extra_options': ['artifact'],

testing/mozharness/configs/builds/releng_sub_mac_configs/64_devedition.py

@@ -5,6 +5,5 @@ config = {
     'stage_product': 'devedition',
 
     # Enable sendchanges for bug 1372412
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': False,
 }

testing/mozharness/configs/builds/releng_sub_mac_configs/64_stat_and_debug.py

@@ -18,7 +18,6 @@ config = {
 clang.manifest",
     'platform_supports_post_upload_to_latest': False,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': False,
     'perfherder_extra_options': ['static-analysis'],
     #### 64 bit build specific #####

testing/mozharness/configs/builds/releng_sub_windows_configs/32_add-on-devel.py

@@ -14,7 +14,6 @@ config = {
     ],
     'stage_platform': 'win32-add-on-devel',
     'build_type': 'add-on-devel',
-    'enable_talos_sendchange': False,
     #### 32 bit build specific #####
     'env': {
         'BINSCOPE': 'C:/Program Files (x86)/Microsoft/SDL BinScope/BinScope.exe',

testing/mozharness/configs/builds/releng_sub_windows_configs/32_debug.py

@@ -14,7 +14,6 @@ config = {
     ],
     'stage_platform': 'win32-debug',
     'debug_build': True,
-    'enable_talos_sendchange': False,
     #### 32 bit build specific #####
     'env': {
         'BINSCOPE': 'C:/Program Files (x86)/Microsoft/SDL BinScope/BinScope.exe',

testing/mozharness/configs/builds/releng_sub_windows_configs/32_stat_and_debug.py

@@ -12,7 +12,6 @@ config = {
     'stage_platform': 'win32-st-an-debug',
     'debug_build': True,
     'enable_signing': False,
-    'enable_talos_sendchange': False,
     'enable_unittest_sendchange': False,
     'tooltool_manifest_src': "browser/config/tooltool-manifests/win32/\
 releng.manifest",

testing/mozharness/configs/builds/releng_sub_windows_configs/64_add-on-devel.py

@@ -14,7 +14,6 @@ config = {
     ],
     'stage_platform': 'win64-add-on-devel',
     'build_type': 'add-on-devel',
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'BINSCOPE': 'C:/Program Files (x86)/Microsoft/SDL BinScope/BinScope.exe',

testing/mozharness/configs/builds/releng_sub_windows_configs/64_debug.py

@@ -14,7 +14,6 @@ config = {
     ],
     'stage_platform': 'win64-debug',
     'debug_build': True,
-    'enable_talos_sendchange': False,
     #### 64 bit build specific #####
     'env': {
         'BINSCOPE': 'C:/Program Files (x86)/Microsoft/SDL BinScope/BinScope.exe',

testing/mozharness/mozharness/mozilla/building/buildbase.py

@@ -2191,11 +2191,6 @@ or run without that action (ie: --no-{action})"
             self.info("We are not running this in buildbot; skipping")
             return
 
-        if self.config.get('enable_talos_sendchange'):
-            self._do_sendchange('talos')
-        else:
-            self.info("'enable_talos_sendchange' is false; skipping")
-
         if self.config.get('enable_unittest_sendchange'):
             self._do_sendchange('unittest')
         else: