Bug 1144438 - Remove false error notification when the profiler stops; r=julienw

If the profiler unexpectedly stops, this is fine, as the new recording infrastructure
is most likely in control of it. This was leading to lots of spurious errors when
working on the new about:profiling infrastructure.

Differential Revision: https://phabricator.services.mozilla.com/D62911

--HG--
extra : moz-landing-system : lando

devtools/server/performance/recorder.js

@@ -162,7 +162,7 @@ PerformanceRecorder.prototype = {
         this._onConsoleProfileEnd(data.details);
       }
     } else if (topic === "profiler-stopped") {
-      this._onProfilerUnexpectedlyStopped();
+      // Some other API stopped the profiler. Ignore it.
     } else if (topic === "profiler-status") {
       this.emit("profiler-status", data);
     }
@@ -243,13 +243,6 @@ PerformanceRecorder.prototype = {
     await this.stopRecording(model);
   },
 
-  /**
-   * TODO handle bug 1144438
-   */
-  _onProfilerUnexpectedlyStopped: function() {
-    Cu.reportError("Profiler unexpectedly stopped.", arguments);
-  },
-
   /**
    * Called whenever there is timeline data of any of the following types:
    * - markers