Bug 1011659 - Remove spammy warnings from APZTestData.h until fixing bug 1007728 makes them non-spammy and meaningful. r=kats

This commit is contained in:
Botond Ballo 2014-05-16 16:13:06 -04:00
Родитель 7db7c28ba4
Коммит 2d70843f72
1 изменённых файлов: 8 добавлений и 14 удалений

Просмотреть файл

@ -42,13 +42,10 @@ class APZTestData {
friend class APZTestDataToJSConverter; friend class APZTestDataToJSConverter;
public: public:
void StartNewPaint(SequenceNumber aSequenceNumber) { void StartNewPaint(SequenceNumber aSequenceNumber) {
auto insertResult = mPaints.insert(DataStore::value_type(aSequenceNumber, Bucket())); mPaints.insert(DataStore::value_type(aSequenceNumber, Bucket()));
if (!insertResult.second) { // TODO(botond): MOZ_ASSERT() that we didn't already have a paint with this
// TODO(botond): Change this to MOZ_ASSERT once we get rid of // sequence number once we get rid ofAPZCTreeManager::UpdatePanZoomControllerTree()
// APZCTreeManager::UpdatePanZoomControllerTree() calls for repeat // calls for repeat transactions (bug 1007728).
// transactions.
NS_WARNING("Already have a paint with this sequence number");
}
} }
void LogTestDataForPaint(SequenceNumber aSequenceNumber, void LogTestDataForPaint(SequenceNumber aSequenceNumber,
ViewID aScrollId, ViewID aScrollId,
@ -96,13 +93,10 @@ private:
} }
Bucket& bucket = bucketIterator->second; Bucket& bucket = bucketIterator->second;
ScrollFrameData& scrollFrameData = bucket[aScrollId]; // create if doesn't exist ScrollFrameData& scrollFrameData = bucket[aScrollId]; // create if doesn't exist
auto insertResult = scrollFrameData.insert(ScrollFrameData::value_type(aKey, aValue)); scrollFrameData.insert(ScrollFrameData::value_type(aKey, aValue));
if (!insertResult.second) { // TODO(botond): MOZ_ASSERT() that we don't already have this key once we
// TODO(botond): Change this to MOZ_ASSERT once we get rid of // get rid of APZCTreeManager::UpdatePanZoomControllerTree() calls for
// APZCTreeManager::UpdatePanZoomControllerTree() calls for repeat // repeat transactions (bug 1007728).
// transactions.
NS_WARNING("Key already present in test data, not overwriting");
}
} }
}; };