Bug 1663963 - Remove expired scroll anchor adjustment telemetry r=rhunt

Differential Revision: https://phabricator.services.mozilla.com/D89650
This commit is contained in:
Barret Rennie 2020-09-10 00:52:39 +00:00
Родитель 447da79e49
Коммит 2db5a81fea
4 изменённых файлов: 0 добавлений и 50 удалений

Просмотреть файл

@ -1376,8 +1376,6 @@ Document::Document(const char* aContentType)
mSubDocuments(nullptr),
mHeaderData(nullptr),
mFlashClassification(FlashClassification::Unknown),
mScrollAnchorAdjustmentLength(0),
mScrollAnchorAdjustmentCount(0),
mServoRestyleRootDirtyBits(0),
mThrowOnDynamicMarkupInsertionCounter(0),
mIgnoreOpensDuringUnloadCounter(0),
@ -9968,11 +9966,6 @@ void Document::RemoveMetaViewportElement(HTMLMetaElement* aElement) {
}
}
void Document::UpdateForScrollAnchorAdjustment(nscoord aLength) {
mScrollAnchorAdjustmentLength += abs(aLength);
mScrollAnchorAdjustmentCount += 1;
}
EventListenerManager* Document::GetOrCreateListenerManager() {
if (!mListenerManager) {
mListenerManager =
@ -15094,15 +15087,6 @@ void Document::ReportUseCounters() {
}
}
}
if (IsTopLevelContentDocument()) {
CSSIntCoord adjustmentLength =
CSSPixel::FromAppUnits(mScrollAnchorAdjustmentLength).Rounded();
Telemetry::Accumulate(Telemetry::SCROLL_ANCHOR_ADJUSTMENT_LENGTH,
adjustmentLength);
Telemetry::Accumulate(Telemetry::SCROLL_ANCHOR_ADJUSTMENT_COUNT,
mScrollAnchorAdjustmentCount);
}
}
void Document::UpdateIntersectionObservations(TimeStamp aNowTime) {

Просмотреть файл

@ -1247,8 +1247,6 @@ class Document : public nsINode,
// Returns a ViewportMetaData for this document.
ViewportMetaData GetViewportMetaData() const;
void UpdateForScrollAnchorAdjustment(nscoord aLength);
/**
* True iff this doc will ignore manual character encoding overrides.
*/
@ -4915,9 +4913,6 @@ class Document : public nsINode,
nsCString mScrollToRef;
nscoord mScrollAnchorAdjustmentLength;
int32_t mScrollAnchorAdjustmentCount;
// Weak reference to the scope object (aka the script global object)
// that, unlike mScriptGlobalObject, is never unset once set. This
// is a weak reference to avoid leaks due to circular references.

Просмотреть файл

@ -490,7 +490,6 @@ void ScrollAnchorContainer::ApplyAdjustments() {
if (mScrollFrame->mIsRoot) {
pc->PresShell()->RootScrollFrameAdjusted(physicalAdjustment.y);
}
pc->Document()->UpdateForScrollAnchorAdjustment(logicalAdjustment);
// The anchor position may not be in the same relative position after
// adjustment. Update ourselves so we have consistent state.

Просмотреть файл

@ -14955,34 +14955,6 @@
"bug_numbers": [1499418],
"description": "GeckoView: Time taken to initialize all GeckoView modules in ms."
},
"SCROLL_ANCHOR_ADJUSTMENT_LENGTH": {
"record_in_processes": ["main", "content"],
"products": ["firefox", "fennec"],
"alert_emails": [
"rhunt@mozilla.com"
],
"expires_in_version": "70",
"kind": "exponential",
"low": 1,
"high": 10000,
"n_buckets": 50,
"bug_numbers": [1518624],
"description": "The absolute length in CSS pixels of all scroll adjustments performed by scroll anchoring in a top-level document."
},
"SCROLL_ANCHOR_ADJUSTMENT_COUNT": {
"record_in_processes": ["main", "content"],
"products": ["firefox", "fennec"],
"alert_emails": [
"rhunt@mozilla.com"
],
"expires_in_version": "70",
"kind": "exponential",
"low": 1,
"high": 500,
"n_buckets": 50,
"bug_numbers": [1518624],
"description": "The amount of scroll adjustments performed by scroll anchoring in a top-level document."
},
"QM_INIT_TELEMETRY_ERROR": {
"record_in_processes": ["main"],
"products": ["firefox", "fennec"],