Bug 1483730 - Return null from getFileForAdb if the adb file doesn't exit. r=jdescottes

Summary: Depends on D3463

Reviewers: jdescottes

Reviewed By: jdescottes

Bug #: 1483730

Differential Revision: https://phabricator.services.mozilla.com/D3464

devtools/shared/adb/adb-binary.js

@@ -216,7 +216,12 @@ async function getFileForBinary() {
       !await extractFiles()) {
     return null;
   }
-  return new FileUtils.File(ADB_BINARY_PATH);
+
+  const file = new FileUtils.File(ADB_BINARY_PATH);
+  if (!file.exists()) {
+    return null;
+  }
+  return file;
 }
 
 exports.getFileForBinary = getFileForBinary;

devtools/shared/adb/test/test_adb.js

@@ -101,9 +101,7 @@ add_task(async function testNoAdbJSON() {
   await extension.unload();
 });
 
-add_task({
-  skip_if: () => mozinfo.os == "win" // bug 1482008
-}, async function testNoTargetBinaries() {
+add_task(async function testNoTargetBinaries() {
   const extension = ExtensionTestUtils.loadExtension({
     manifest: {
       version: (extension_version++).toString(),