Bug 1521719 - Stop the legacy urlbar binding being constructed and registering listeners when QuantumBar is enabled. r=dao

As a result, we can also re-enable some tests running against QuantumBar.

Differential Revision: https://phabricator.services.mozilla.com/D17352

--HG--
extra : moz-landing-system : lando

browser/base/content/browser.css

@@ -551,8 +551,10 @@ toolbar:not(#TabsToolbar) > #personal-bookmarks {
   -moz-binding: url(chrome://browser/content/urlbarBindings.xml#legacy-urlbar);
 }
 
-#urlbar[quantumbar] {
-  -moz-binding: url(chrome://browser/content/urlbarBindings.xml#urlbar);
+@supports -moz-bool-pref("browser.urlbar.quantumbar") {
+  #urlbar {
+    -moz-binding: url(chrome://browser/content/urlbarBindings.xml#urlbar);
+  }
 }
 
 /* Display URLs left-to-right but right aligned in RTL mode. */

browser/base/content/browser.js

@@ -190,9 +190,6 @@ XPCOMUtils.defineLazyGetter(this, "gURLBar", () => {
     return element;
   }
 
-  // Disable the legacy XBL binding.
-  element.setAttribute("quantumbar", "true");
-
   // Re-focus the input field if it was focused before switching bindings.
   if (element.hasAttribute("focused")) {
     element.inputField.focus();

browser/components/urlbar/tests/browser/browser.ini

@@ -41,7 +41,6 @@ skip-if = os != "win" # Windows only feature
 support-files =
   file_blank_but_not_blank.html
 [browser_urlbar_content_opener.js]
-skip-if = debug # Bug 1521835 - shutdown leaks
 [browser_urlbar_locationchange_urlbar_edit_dos.js]
 support-files =
   file_urlbar_edit_dos.html
@@ -54,7 +53,6 @@ subsuite = clipboard
 support-files =
   authenticate.sjs
 [browser_urlbarEnter.js]
-skip-if = true # Bug 1521490
 [browser_urlbarFocusedCmdK.js]
 [browser_urlbarHashChangeProxyState.js]
 [browser_UrlbarInput_formatValue.js]
@@ -65,16 +63,14 @@ subsuite = clipboard
 [browser_UrlbarInput_unit.js]
 support-files = empty.xul
 [browser_UrlbarLoadRace.js]
-skip-if = true # Bug 1521490
 [browser_urlbarPlaceholder.js]
 support-files =
   searchSuggestionEngine.xml
   searchSuggestionEngine.sjs
 [browser_urlbarRevert.js]
 [browser_urlbarSearchSingleWordNotification.js]
-skip-if = debug # Bug 1521513 - shutdown leaks.
 [browser_URLBarSetURI.js]
-skip-if = debug # Linux & Mac: bug 970052 and bug 970053. Windows: bug 1521532
+skip-if = (os == "linux" || os == "mac") && debug # bug 970052, bug 970053
 [browser_urlbarUpdateForDomainCompletion.js]
 [browser_wyciwyg_urlbarCopying.js]
 subsuite = clipboard

browser/themes/shared/urlbar-searchbar.inc.css

@@ -318,8 +318,10 @@
 }
 
 /* Avoid re-opening the popup when the dropmarker is clicked while the popup is still open. */
-#urlbar:not([quantumbar]) > .urlbar-history-dropmarker[open] {
-  pointer-events: none;
+@supports not -moz-bool-pref("browser.urlbar.quantumbar") {
+  .urlbar-history-dropmarker[open] {
+    pointer-events: none;
+  }
 }
 
 #urlbar[switchingtabs] > .urlbar-history-dropmarker {