Bug 627498 - Call GfxInfo::Init on all platforms that implement GfxInfo. r=jrmuizel a=b

widget/src/android/nsWidgetFactory.cpp

@@ -80,7 +80,8 @@ NS_GENERIC_FACTORY_CONSTRUCTOR(nsIMEPicker)
 #include "GfxInfo.h"
 namespace mozilla {
 namespace widget {
-NS_GENERIC_FACTORY_CONSTRUCTOR(GfxInfo)
+// This constructor should really be shared with all platforms.
+NS_GENERIC_FACTORY_CONSTRUCTOR_INIT(GfxInfo, Init)
 }
 }
 

widget/src/build/nsWinWidgetFactory.cpp

@@ -103,6 +103,7 @@ NS_GENERIC_FACTORY_CONSTRUCTOR(JumpListShortcut)
 
 namespace mozilla {
 namespace widget {
+// This constructor should really be shared with all platforms.
 NS_GENERIC_FACTORY_CONSTRUCTOR_INIT(GfxInfo, Init);
 }
 }

widget/src/cocoa/nsWidgetFactory.mm

@@ -102,7 +102,8 @@ NS_GENERIC_FACTORY_CONSTRUCTOR(nsStandaloneNativeMenu)
 #include "GfxInfo.h"
 namespace mozilla {
 namespace widget {
-NS_GENERIC_FACTORY_CONSTRUCTOR(GfxInfo)
+// This constructor should really be shared with all platforms.
+NS_GENERIC_FACTORY_CONSTRUCTOR_INIT(GfxInfo, Init)
 }
 }
 

widget/src/xpwidgets/GfxInfoBase.h

@@ -74,6 +74,9 @@ public:
 
   // Initialization function. If you override this, you must call this class's
   // version of Init first.
+  // We need Init to be called separately from the constructor so we can
+  // register as an observer after all derived classes have been constructed
+  // and we know we have a non-zero refcount.
   // Ideally, Init() would be void-return, but the rules of
   // NS_GENERIC_FACTORY_CONSTRUCTOR_INIT require it be nsresult return.
   virtual nsresult Init();