Make thread state changes opt-in for clients with an onThreadState handler (bug 1037514); r=fitzgen

--HG--
extra : rebase_source : 94232bb18e4f3dbeef3df827b05b5cc1be37b36e

toolkit/devtools/client/dbg-client.jsm

@@ -66,7 +66,7 @@ let wantVerbose =
   Services.prefs.getPrefType(VERBOSE_PREF) !== Services.prefs.PREF_INVALID &&
   Services.prefs.getBoolPref(VERBOSE_PREF);
 
-let noop = () => {};
+const noop = () => {};
 
 function dumpn(str) {
   if (wantLogging) {
@@ -901,7 +901,8 @@ DebuggerClient.prototype = {
 
       // Packets that indicate thread state changes get special treatment.
       if (aPacket.type in ThreadStateTypes &&
-          this._clients.has(aPacket.from)) {
+          this._clients.has(aPacket.from) &&
+          typeof this._clients.get(aPacket.from)._onThreadState == "function") {
         this._clients.get(aPacket.from)._onThreadState(aPacket);
       }
       // On navigation the server resumes, so the client must resume as well.
@@ -2683,11 +2684,3 @@ this.debuggerSocketConnect = function (aHost, aPort)
   }
   return transport;
 }
-
-/**
- * Takes a pair of items and returns them as an array.
- */
-function pair(aItemOne, aItemTwo) {
-  return [aItemOne, aItemTwo];
-}
-function noop() {}