Backed out changeset a13d1af8d1b5 (bug 1558522) for Crashtest failures in reftest/tests/xpcom/string/crashtests/1113005.html. CLOSED TREE

2019-11-19 19:23:28 +02:00 · 2019-11-19 19:23:28 +02:00 · 30c26d0a23
--- a/dom/indexedDB/IDBDatabase.cpp
+++ b/dom/indexedDB/IDBDatabase.cpp
@ -1072,9 +1072,6 @@ void IDBDatabase::LastRelease() {

  CloseInternal();

-  // If the database was already closed, CloseInternal does not expire file
-  // actors, which might have been acquired after the close actually happened,
-  // so we expire them here again to be safe (cf. bug 1558522).
  ExpireFileActors(/* aExpireAll */ true);

  if (mBackgroundActor) {
--- a/dom/indexedDB/crashtests/1558522-1.html
+++ b/dom/indexedDB/crashtests/1558522-1.html
@ -1,40 +0,0 @@
-<html>
-<head>
-    <script id='worker' type='javascript/worker'>
-      onmessage = function (e) {
-        const file = e.data[0]
-        const db = indexedDB.open('', {})
-        db.onupgradeneeded = function (event) {
-          const store = event.target.result.createObjectStore('IDBStore_0', {})
-          store.add({}, '')
-        }
-        db.onsuccess = function (event) {
-          const transaction = event.target.result.transaction('IDBStore_0', 'readwrite')
-          const store = transaction.objectStore('IDBStore_0')
-          const cursor = store.openCursor()
-          cursor.onsuccess = function (event) {
-            event.target.result.update({
-              data: file
-            })
-            event.target.result.advance(1)
-          }
-
-          event.target.result.close()
-        }
-      }
-
-    </script>
-    <script>
-      let worker;
-
-      function start () {
-        const file = new File([], 'x')
-        const blob = new Blob([document.getElementById('worker').textContent], { type: 'text/javascript' })
-        worker = new Worker(window.URL.createObjectURL(blob))
-        worker.postMessage([file], [])
-      }
-
-      document.addEventListener('DOMContentLoaded', start)
-    </script>
-</head>
-</html>
--- a/dom/indexedDB/crashtests/crashtests.list
+++ b/dom/indexedDB/crashtests/crashtests.list
@ -2,4 +2,3 @@ load 726376-1.html
 load 1499854-1.html
 load 1505821-1.html
 load 1507229-1.html
-load 1558522-1.html