From 30ea634bb08e4e4cf5b99c1e4047feb49993fd32 Mon Sep 17 00:00:00 2001 From: Paolo Amadini Date: Thu, 25 May 2017 15:00:49 +0100 Subject: [PATCH] Bug 1242505 - Part 5 - Remove obsolete whitelisting of unhandled rejections. r=Mossop The whitelisting function thisTestLeaksUncaughtRejectionsAndShouldBeFixed was replaced by expectUncaughtRejection, and existing calls did not take effect anymore. MozReview-Commit-ID: 3uOxkgWYWEz --HG-- extra : rebase_source : 5a10a3ebbfe0ce2a801330041f95447c313a9a70 extra : source : 6f0394b523a66dab444b8551deb8f3c6c81d8f31 --- .../browser_aboutSupport_newtab_security_state.js | 7 ------- browser/base/content/test/general/browser_scope.js | 6 ------ .../base/content/test/general/browser_tabs_owner.js | 12 ------------ .../content/test/social/browser_social_activation.js | 7 ------- .../base/content/test/sync/browser_aboutAccounts.js | 6 ------ .../test/functional/mochitest/.eslintrc.js | 1 - .../client/debugger/new/test/mochitest/.eslintrc | 1 - .../test/mochitest/browser_dbg_break-on-dom-01.js | 6 ------ .../mochitest/browser_dbg_terminate-on-tab-close.js | 4 ---- .../test/mochitest/browser_dbg_worker-window.js | 4 ---- .../client/framework/test/browser_devtools_api.js | 9 --------- .../framework/test/browser_toolbox_tool_ready.js | 7 ------- .../test/browser_toolbox_tool_remote_reopen.js | 7 ------- .../test/browser_computed_style-editor-link.js | 4 ---- .../rules/test/browser_rules_style-editor-link.js | 4 ---- .../test/browser_inspector_highlighter-comments.js | 6 ------ .../test/browser_projecteditor_editing_01.js | 6 ------ .../test/browser_projecteditor_editors_image.js | 6 ------ .../test/browser_projecteditor_immediate_destroy.js | 7 ------- .../test/browser_projecteditor_saveall.js | 6 ------ .../test/browser_projecteditor_tree_selection_02.js | 6 ------ .../responsivedesign/test/browser_responsive_cmd.js | 6 ------ .../browser_telemetry_toolboxtabs_shadereditor.js | 7 ------- .../client/shared/test/browser_toolbar_tooltip.js | 8 -------- .../webaudioeditor/test/browser_wa_first-run.js | 6 ------ .../webaudioeditor/test/browser_wa_reset-01.js | 6 ------ .../webaudioeditor/test/browser_wa_reset-04.js | 6 ------ .../webconsole/test/browser_webconsole_output_01.js | 2 -- .../webconsole/test/browser_webconsole_output_04.js | 2 -- .../browser_webconsole_output_dom_elements_01.js | 4 ---- .../test/browser_webconsole_output_events.js | 2 -- testing/mochitest/browser-test.js | 3 --- .../startup/tests/browser/browser_bug537449.js | 6 ------ .../extensions/test/browser/browser_bug570760.js | 3 --- .../extensions/test/xpinstall/browser_auth3.js | 7 ------- .../extensions/test/xpinstall/browser_auth4.js | 8 -------- .../lib/configs/browser-test.js | 1 - 37 files changed, 199 deletions(-) diff --git a/browser/base/content/test/general/browser_aboutSupport_newtab_security_state.js b/browser/base/content/test/general/browser_aboutSupport_newtab_security_state.js index 4148ec68dcec..1df0b0506264 100644 --- a/browser/base/content/test/general/browser_aboutSupport_newtab_security_state.js +++ b/browser/base/content/test/general/browser_aboutSupport_newtab_security_state.js @@ -1,13 +1,6 @@ /* Any copyright is dedicated to the Public Domain. * http://creativecommons.org/publicdomain/zero/1.0/ */ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: window.location is null"); - - add_task(async function checkIdentityOfAboutSupport() { let tab = gBrowser.loadOneTab("about:support", { referrerURI: null, diff --git a/browser/base/content/test/general/browser_scope.js b/browser/base/content/test/general/browser_scope.js index f8141e5f67ee..e4edac1e0449 100644 --- a/browser/base/content/test/general/browser_scope.js +++ b/browser/base/content/test/general/browser_scope.js @@ -1,9 +1,3 @@ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: this.docShell is null"); - function test() { ok(!!gBrowser, "gBrowser exists"); is(gBrowser, getBrowser(), "both ways of getting tabbrowser work"); diff --git a/browser/base/content/test/general/browser_tabs_owner.js b/browser/base/content/test/general/browser_tabs_owner.js index 2ea14fd88587..abafed517f12 100644 --- a/browser/base/content/test/general/browser_tabs_owner.js +++ b/browser/base/content/test/general/browser_tabs_owner.js @@ -1,15 +1,3 @@ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: gBrowser._finalizeTabSwitch is not a function"); - -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: gBrowser._finalizeTabSwitch is not a function"); - function test() { BrowserTestUtils.addTab(gBrowser); BrowserTestUtils.addTab(gBrowser); diff --git a/browser/base/content/test/social/browser_social_activation.js b/browser/base/content/test/social/browser_social_activation.js index 3914e74e5676..61461a03562d 100644 --- a/browser/base/content/test/social/browser_social_activation.js +++ b/browser/base/content/test/social/browser_social_activation.js @@ -2,13 +2,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: Assert is null"); - - var SocialService = Cu.import("resource:///modules/SocialService.jsm", {}).SocialService; var tabsToRemove = []; diff --git a/browser/base/content/test/sync/browser_aboutAccounts.js b/browser/base/content/test/sync/browser_aboutAccounts.js index 66587dfbd052..3f199f2cc10e 100644 --- a/browser/base/content/test/sync/browser_aboutAccounts.js +++ b/browser/base/content/test/sync/browser_aboutAccounts.js @@ -2,12 +2,6 @@ * http://creativecommons.org/publicdomain/zero/1.0/ */ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: window.location is null"); - XPCOMUtils.defineLazyModuleGetter(this, "Promise", "resource://gre/modules/Promise.jsm"); XPCOMUtils.defineLazyModuleGetter(this, "fxAccounts", diff --git a/browser/extensions/activity-stream/test/functional/mochitest/.eslintrc.js b/browser/extensions/activity-stream/test/functional/mochitest/.eslintrc.js index b1148a7004e8..3f749b7cfab0 100644 --- a/browser/extensions/activity-stream/test/functional/mochitest/.eslintrc.js +++ b/browser/extensions/activity-stream/test/functional/mochitest/.eslintrc.js @@ -31,7 +31,6 @@ module.exports = { "SimpleTest": false, "SpecialPowers": false, "TestUtils": false, - "thisTestLeaksUncaughtRejectionsAndShouldBeFixed": false, "todo": false, "todo_is": false, "todo_isnot": false, diff --git a/devtools/client/debugger/new/test/mochitest/.eslintrc b/devtools/client/debugger/new/test/mochitest/.eslintrc index 017b921f84a5..d6b0ce9d274b 100644 --- a/devtools/client/debugger/new/test/mochitest/.eslintrc +++ b/devtools/client/debugger/new/test/mochitest/.eslintrc @@ -26,7 +26,6 @@ "SimpleTest": false, "SpecialPowers": false, "TestUtils": false, - "thisTestLeaksUncaughtRejectionsAndShouldBeFixed": false, "todo": false, "todo_is": false, "todo_isnot": false, diff --git a/devtools/client/debugger/test/mochitest/browser_dbg_break-on-dom-01.js b/devtools/client/debugger/test/mochitest/browser_dbg_break-on-dom-01.js index 82481187aaeb..f47059f17cce 100644 --- a/devtools/client/debugger/test/mochitest/browser_dbg_break-on-dom-01.js +++ b/devtools/client/debugger/test/mochitest/browser_dbg_break-on-dom-01.js @@ -3,12 +3,6 @@ /* Any copyright is dedicated to the Public Domain. * http://creativecommons.org/publicdomain/zero/1.0/ */ -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejections should be fixed. -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("[object Object]"); -thisTestLeaksUncaughtRejectionsAndShouldBeFixed( - "TypeError: this.transport is null"); - /** * Tests that event listeners aren't fetched when the events tab isn't selected. */ diff --git a/devtools/client/debugger/test/mochitest/browser_dbg_terminate-on-tab-close.js b/devtools/client/debugger/test/mochitest/browser_dbg_terminate-on-tab-close.js index 2b8a66a88f7a..eedbbd490b15 100644 --- a/devtools/client/debugger/test/mochitest/browser_dbg_terminate-on-tab-close.js +++ b/devtools/client/debugger/test/mochitest/browser_dbg_terminate-on-tab-close.js @@ -3,10 +3,6 @@ /* Any copyright is dedicated to the Public Domain. * http://creativecommons.org/publicdomain/zero/1.0/ */ -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejections should be fixed. -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("[object Object]"); - /** * Tests that debuggee scripts are terminated on tab closure. */ diff --git a/devtools/client/debugger/test/mochitest/browser_dbg_worker-window.js b/devtools/client/debugger/test/mochitest/browser_dbg_worker-window.js index 737a68f54179..428132ff231d 100644 --- a/devtools/client/debugger/test/mochitest/browser_dbg_worker-window.js +++ b/devtools/client/debugger/test/mochitest/browser_dbg_worker-window.js @@ -3,10 +3,6 @@ "use strict"; -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejections should be fixed. -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("[object Object]"); - // The following "connectionClosed" rejection should not be left uncaught. This // test has been whitelisted until the issue is fixed. Cu.import("resource://testing-common/PromiseTestUtils.jsm", this); diff --git a/devtools/client/framework/test/browser_devtools_api.js b/devtools/client/framework/test/browser_devtools_api.js index 7c15412e8ce6..4eb45c52d802 100644 --- a/devtools/client/framework/test/browser_devtools_api.js +++ b/devtools/client/framework/test/browser_devtools_api.js @@ -3,15 +3,6 @@ /* Any copyright is dedicated to the Public Domain. * http://creativecommons.org/publicdomain/zero/1.0/ */ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejections should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: this.docShell is null"); - -// When running in a standalone directory, we get this error -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: this.doc is undefined"); - // Tests devtools API const toolId1 = "test-tool-1"; diff --git a/devtools/client/framework/test/browser_toolbox_tool_ready.js b/devtools/client/framework/test/browser_toolbox_tool_ready.js index 7d430e7c5314..e7fb1f9c17ae 100644 --- a/devtools/client/framework/test/browser_toolbox_tool_ready.js +++ b/devtools/client/framework/test/browser_toolbox_tool_ready.js @@ -7,13 +7,6 @@ requestLongerTimeout(5); -/** - * Whitelisting this test. - * As part of bug 1077403, the leaking uncaught rejection should be fixed. - */ -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("Error: Shader Editor is " + - "still waiting for a WebGL context to be created."); - function performChecks(target) { return Task.spawn(function* () { let toolIds = gDevTools.getToolDefinitionArray() diff --git a/devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js b/devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js index 03461e953392..2d5a82498fe0 100644 --- a/devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js +++ b/devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js @@ -5,13 +5,6 @@ "use strict"; -/** - * Whitelisting this test. - * As part of bug 1077403, the leaking uncaught rejection should be fixed. - */ -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("Error: Shader Editor is " + - "still waiting for a WebGL context to be created."); - const { DebuggerServer } = require("devtools/server/main"); const { DebuggerClient } = require("devtools/shared/client/main"); diff --git a/devtools/client/inspector/computed/test/browser_computed_style-editor-link.js b/devtools/client/inspector/computed/test/browser_computed_style-editor-link.js index 6a95fd83fe89..bd738a49d9b6 100644 --- a/devtools/client/inspector/computed/test/browser_computed_style-editor-link.js +++ b/devtools/client/inspector/computed/test/browser_computed_style-editor-link.js @@ -4,10 +4,6 @@ "use strict"; -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("Error: Unknown sheet source"); - // Tests the links from the computed view to the style editor. const STYLESHEET_URL = "data:text/css," + encodeURIComponent( diff --git a/devtools/client/inspector/rules/test/browser_rules_style-editor-link.js b/devtools/client/inspector/rules/test/browser_rules_style-editor-link.js index 927deb8ce3c6..59f2a2cdc93d 100644 --- a/devtools/client/inspector/rules/test/browser_rules_style-editor-link.js +++ b/devtools/client/inspector/rules/test/browser_rules_style-editor-link.js @@ -4,10 +4,6 @@ "use strict"; -// FIXME: Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("Error: Unknown sheet source"); - // Test the links from the rule-view to the styleeditor const STYLESHEET_URL = "data:text/css," + encodeURIComponent( diff --git a/devtools/client/inspector/test/browser_inspector_highlighter-comments.js b/devtools/client/inspector/test/browser_inspector_highlighter-comments.js index 104395227f9d..7aeeb532f5d5 100644 --- a/devtools/client/inspector/test/browser_inspector_highlighter-comments.js +++ b/devtools/client/inspector/test/browser_inspector_highlighter-comments.js @@ -5,12 +5,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ "use strict"; -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("false"); - // Test that hovering over the markup-view's containers doesn't always show the // highlighter, depending on the type of node hovered over. diff --git a/devtools/client/projecteditor/test/browser_projecteditor_editing_01.js b/devtools/client/projecteditor/test/browser_projecteditor_editing_01.js index c7ff1c0be9d2..287a6fdf5c0f 100644 --- a/devtools/client/projecteditor/test/browser_projecteditor_editing_01.js +++ b/devtools/client/projecteditor/test/browser_projecteditor_editing_01.js @@ -4,12 +4,6 @@ "use strict"; -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy"); - loadHelperScript("helper_edits.js"); // Test ProjectEditor basic functionality diff --git a/devtools/client/projecteditor/test/browser_projecteditor_editors_image.js b/devtools/client/projecteditor/test/browser_projecteditor_editors_image.js index 0b19cb5d14b2..dcd3589a74cf 100644 --- a/devtools/client/projecteditor/test/browser_projecteditor_editors_image.js +++ b/devtools/client/projecteditor/test/browser_projecteditor_editors_image.js @@ -4,12 +4,6 @@ "use strict"; -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy"); - loadHelperScript("helper_edits.js"); // Test ProjectEditor image editor functionality diff --git a/devtools/client/projecteditor/test/browser_projecteditor_immediate_destroy.js b/devtools/client/projecteditor/test/browser_projecteditor_immediate_destroy.js index 943a9e82d6c1..09abde5d7f6b 100644 --- a/devtools/client/projecteditor/test/browser_projecteditor_immediate_destroy.js +++ b/devtools/client/projecteditor/test/browser_projecteditor_immediate_destroy.js @@ -4,13 +4,6 @@ "use strict"; -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy"); -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: this.window is null"); - // Test that projecteditor can be destroyed in various states of loading // without causing any leaks or exceptions. diff --git a/devtools/client/projecteditor/test/browser_projecteditor_saveall.js b/devtools/client/projecteditor/test/browser_projecteditor_saveall.js index 2468ea4fcce2..08801fa74ec3 100644 --- a/devtools/client/projecteditor/test/browser_projecteditor_saveall.js +++ b/devtools/client/projecteditor/test/browser_projecteditor_saveall.js @@ -4,12 +4,6 @@ "use strict"; -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy"); - loadHelperScript("helper_edits.js"); // Test ProjectEditor basic functionality diff --git a/devtools/client/projecteditor/test/browser_projecteditor_tree_selection_02.js b/devtools/client/projecteditor/test/browser_projecteditor_tree_selection_02.js index 51826e4dc2d0..daf6c3eb441e 100644 --- a/devtools/client/projecteditor/test/browser_projecteditor_tree_selection_02.js +++ b/devtools/client/projecteditor/test/browser_projecteditor_tree_selection_02.js @@ -4,12 +4,6 @@ "use strict"; -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy"); - // Test that files get reselected in the tree when their editor // is focused. https://bugzilla.mozilla.org/show_bug.cgi?id=1011116. diff --git a/devtools/client/responsivedesign/test/browser_responsive_cmd.js b/devtools/client/responsivedesign/test/browser_responsive_cmd.js index 8c8e798d0558..7fd3697d516e 100644 --- a/devtools/client/responsivedesign/test/browser_responsive_cmd.js +++ b/devtools/client/responsivedesign/test/browser_responsive_cmd.js @@ -3,12 +3,6 @@ "use strict"; -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("destroy"); - function test() { let manager = ResponsiveUIManager; let done; diff --git a/devtools/client/shared/test/browser_telemetry_toolboxtabs_shadereditor.js b/devtools/client/shared/test/browser_telemetry_toolboxtabs_shadereditor.js index 5cf1eb0a6b8a..4829362fac57 100644 --- a/devtools/client/shared/test/browser_telemetry_toolboxtabs_shadereditor.js +++ b/devtools/client/shared/test/browser_telemetry_toolboxtabs_shadereditor.js @@ -3,13 +3,6 @@ "use strict"; -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed( - "Error: Shader Editor is still waiting for a WebGL context to be created."); - const TEST_URI = "data:text/html;charset=utf-8," + "

browser_telemetry_toolboxtabs_shadereditor.js

"; diff --git a/devtools/client/shared/test/browser_toolbar_tooltip.js b/devtools/client/shared/test/browser_toolbar_tooltip.js index bc09f705ce6f..301717939d8a 100644 --- a/devtools/client/shared/test/browser_toolbar_tooltip.js +++ b/devtools/client/shared/test/browser_toolbar_tooltip.js @@ -5,14 +5,6 @@ // Tests that the developer toolbar works properly -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed( - "Protocol error (unknownError): Error: Got an invalid root window in DocumentWalker" -); - const TEST_URI = "data:text/html;charset=utf-8,

Tooltip Tests

"; const PREF_DEVTOOLS_THEME = "devtools.theme"; diff --git a/devtools/client/webaudioeditor/test/browser_wa_first-run.js b/devtools/client/webaudioeditor/test/browser_wa_first-run.js index d2d96932e557..76db921ba10d 100644 --- a/devtools/client/webaudioeditor/test/browser_wa_first-run.js +++ b/devtools/client/webaudioeditor/test/browser_wa_first-run.js @@ -1,12 +1,6 @@ /* Any copyright is dedicated to the Public Domain. http://creativecommons.org/publicdomain/zero/1.0/ */ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("Error: Connection closed"); - /** * Tests that the reloading/onContentLoaded hooks work. */ diff --git a/devtools/client/webaudioeditor/test/browser_wa_reset-01.js b/devtools/client/webaudioeditor/test/browser_wa_reset-01.js index 67a0c33ffdc8..2afe614d306a 100644 --- a/devtools/client/webaudioeditor/test/browser_wa_reset-01.js +++ b/devtools/client/webaudioeditor/test/browser_wa_reset-01.js @@ -1,12 +1,6 @@ /* Any copyright is dedicated to the Public Domain. http://creativecommons.org/publicdomain/zero/1.0/ */ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("Error: Connection closed"); - /** * Tests that reloading a tab will properly listen for the `start-context` * event and reshow the tools after reloading. diff --git a/devtools/client/webaudioeditor/test/browser_wa_reset-04.js b/devtools/client/webaudioeditor/test/browser_wa_reset-04.js index 7ad009020f0c..c0a45a49e867 100644 --- a/devtools/client/webaudioeditor/test/browser_wa_reset-04.js +++ b/devtools/client/webaudioeditor/test/browser_wa_reset-04.js @@ -1,12 +1,6 @@ /* Any copyright is dedicated to the Public Domain. http://creativecommons.org/publicdomain/zero/1.0/ */ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("Error: Connection closed"); - /** * Tests that switching to an iframe works fine. */ diff --git a/devtools/client/webconsole/test/browser_webconsole_output_01.js b/devtools/client/webconsole/test/browser_webconsole_output_01.js index c75577ea7728..bc779705e4ec 100644 --- a/devtools/client/webconsole/test/browser_webconsole_output_01.js +++ b/devtools/client/webconsole/test/browser_webconsole_output_01.js @@ -9,8 +9,6 @@ "use strict"; -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("null"); - // Test the webconsole output for various types of objects. const TEST_URI = "data:text/html;charset=utf8,test for console output - 01"; diff --git a/devtools/client/webconsole/test/browser_webconsole_output_04.js b/devtools/client/webconsole/test/browser_webconsole_output_04.js index d829594a75c9..d4d5f8b50b9b 100644 --- a/devtools/client/webconsole/test/browser_webconsole_output_04.js +++ b/devtools/client/webconsole/test/browser_webconsole_output_04.js @@ -9,8 +9,6 @@ "use strict"; -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("null"); - // Test the webconsole output for various types of objects. const TEST_URI = "http://example.com/browser/devtools/client/webconsole/" + diff --git a/devtools/client/webconsole/test/browser_webconsole_output_dom_elements_01.js b/devtools/client/webconsole/test/browser_webconsole_output_dom_elements_01.js index 097eb3b370c8..c6c8c511fed9 100644 --- a/devtools/client/webconsole/test/browser_webconsole_output_dom_elements_01.js +++ b/devtools/client/webconsole/test/browser_webconsole_output_dom_elements_01.js @@ -8,10 +8,6 @@ "use strict"; -thisTestLeaksUncaughtRejectionsAndShouldBeFixed(null); -thisTestLeaksUncaughtRejectionsAndShouldBeFixed( - "TypeError: this.toolbox is null"); - // Test the webconsole output for various types of DOM Nodes. const TEST_URI = "http://example.com/browser/devtools/client/webconsole/" + diff --git a/devtools/client/webconsole/test/browser_webconsole_output_events.js b/devtools/client/webconsole/test/browser_webconsole_output_events.js index 9bd04bfc7cfe..8091487a1295 100644 --- a/devtools/client/webconsole/test/browser_webconsole_output_events.js +++ b/devtools/client/webconsole/test/browser_webconsole_output_events.js @@ -8,8 +8,6 @@ "use strict"; -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("null"); - // Test the webconsole output for DOM events. const TEST_URI = "http://example.com/browser/devtools/client/webconsole/" + diff --git a/testing/mochitest/browser-test.js b/testing/mochitest/browser-test.js index 6861c06920b9..b358fc6dd85c 100644 --- a/testing/mochitest/browser-test.js +++ b/testing/mochitest/browser-test.js @@ -1034,9 +1034,6 @@ function testScope(aTester, aTest, expected) { self.SimpleTest.ignoreAllUncaughtExceptions(aIgnoring); }; - this.thisTestLeaksUncaughtRejectionsAndShouldBeFixed = function(...rejections) { - }; - this.expectAssertions = function test_expectAssertions(aMin, aMax) { let min = aMin; let max = aMax; diff --git a/toolkit/components/startup/tests/browser/browser_bug537449.js b/toolkit/components/startup/tests/browser/browser_bug537449.js index 88d592c458d8..1d4c93f32481 100644 --- a/toolkit/components/startup/tests/browser/browser_bug537449.js +++ b/toolkit/components/startup/tests/browser/browser_bug537449.js @@ -4,12 +4,6 @@ "use strict"; -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: this.docShell is null"); - SpecialPowers.pushPrefEnv({"set": [["dom.require_user_interaction_for_beforeunload", false]]}); const TEST_URL = "http://example.com/browser/toolkit/components/startup/tests/browser/beforeunload.html"; diff --git a/toolkit/mozapps/extensions/test/browser/browser_bug570760.js b/toolkit/mozapps/extensions/test/browser/browser_bug570760.js index 0606a9a3108b..3150d58780de 100644 --- a/toolkit/mozapps/extensions/test/browser/browser_bug570760.js +++ b/toolkit/mozapps/extensions/test/browser/browser_bug570760.js @@ -2,9 +2,6 @@ * http://creativecommons.org/publicdomain/zero/1.0/ */ -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -thisTestLeaksUncaughtRejectionsAndShouldBeFixed(""); - // Bug 570760 - Make ctrl-f and / focus the search box in the add-ons manager var gManagerWindow; diff --git a/toolkit/mozapps/extensions/test/xpinstall/browser_auth3.js b/toolkit/mozapps/extensions/test/xpinstall/browser_auth3.js index 1618fa3cb12c..d15b547e3f85 100644 --- a/toolkit/mozapps/extensions/test/xpinstall/browser_auth3.js +++ b/toolkit/mozapps/extensions/test/xpinstall/browser_auth3.js @@ -3,13 +3,6 @@ // canceled // This verifies bug 312473 -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: this.docShell is null"); - - function test() { Harness.authenticationCallback = get_auth_info; Harness.downloadFailedCallback = download_failed; diff --git a/toolkit/mozapps/extensions/test/xpinstall/browser_auth4.js b/toolkit/mozapps/extensions/test/xpinstall/browser_auth4.js index 4ab5abc7ea2f..a8887b29c8c3 100644 --- a/toolkit/mozapps/extensions/test/xpinstall/browser_auth4.js +++ b/toolkit/mozapps/extensions/test/xpinstall/browser_auth4.js @@ -1,11 +1,3 @@ -// -// Whitelisting this test. -// As part of bug 1077403, the leaking uncaught rejection should be fixed. -// -thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: this.docShell is null"); - - -// ---------------------------------------------------------------------------- // Test whether a request for auth for an XPI switches to the appropriate tab var gNewTab; diff --git a/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/browser-test.js b/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/browser-test.js index 391746d01c07..6fd8ecb55440 100644 --- a/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/browser-test.js +++ b/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/browser-test.js @@ -45,7 +45,6 @@ module.exports = { "privateNoteIntentionalCrash": false, "registerCleanupFunction": false, "requestLongerTimeout": false, - "thisTestLeaksUncaughtRejectionsAndShouldBeFixed": false, "todo": false, "todo_is": false, "todo_isnot": false,