Bug 1542155 - LSNG: Convert MOZ_ALWAYS_TRUE(SendFinish()) to MOZ_DIAGNOSTIC_ALWAYS_TRUE(SendFinish()); r=asuth

dom/localstorage/ActorsChild.cpp

@@ -193,7 +193,7 @@ mozilla::ipc::IPCResult LSRequestChild::RecvReady() {
 
   // We only expect this to return false if the channel has been closed, but
   // PBackground's channel never gets shutdown.
-  MOZ_ALWAYS_TRUE(SendFinish());
+  MOZ_DIAGNOSTIC_ALWAYS_TRUE(SendFinish());
 
   return IPC_OK();
 }