Bug 1574831 - Pass the object to onDOMNodeMouseOut in the reps. r=nchevobbe

Differential Revision: https://phabricator.services.mozilla.com/D42444

--HG--
extra : moz-landing-system : lando

devtools/client/debugger/packages/devtools-reps/src/reps/element-node.js

@@ -65,7 +65,7 @@ function ElementNode(props) {
 
     if (onDOMNodeMouseOut) {
       Object.assign(baseConfig, {
-        onMouseOut: onDOMNodeMouseOut,
+        onMouseOut: _ => onDOMNodeMouseOut(object),
       });
     }
 

devtools/client/debugger/packages/devtools-reps/src/reps/tests/element-node.js

@@ -160,6 +160,7 @@ describe("ElementNode - Node", () => {
     renderedComponent.simulate("mouseout");
 
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(1);
+    expect(onDOMNodeMouseOut.mock.calls[0][0]).toEqual(stub);
   });
 
   it("calls the expected function when mouseover is fired on Rep", () => {

devtools/client/debugger/packages/devtools-reps/src/reps/tests/event.js

@@ -126,6 +126,7 @@ describe("Event - mouse event", () => {
     node.simulate("mouseout");
 
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(1);
+    expect(onDOMNodeMouseOut.mock.calls[0][0]).toEqual(grips[0]);
   });
 
   it("calls the expected function when mouseover is fired on Rep", () => {

devtools/client/debugger/packages/devtools-reps/src/reps/tests/grip-array.js

@@ -386,6 +386,9 @@ describe("GripArray - NodeList", () => {
     node.at(2).simulate("mouseout");
 
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(3);
+    expect(onDOMNodeMouseOut.mock.calls[0][0]).toBe(grips[0]);
+    expect(onDOMNodeMouseOut.mock.calls[1][0]).toBe(grips[1]);
+    expect(onDOMNodeMouseOut.mock.calls[2][0]).toBe(grips[2]);
   });
 
   it("calls the expected function on click", () => {

devtools/client/debugger/packages/devtools-reps/src/reps/tests/grip-map-entry.js

@@ -147,6 +147,7 @@ describe("GripMapEntry - complex", () => {
 
     node.simulate("mouseout");
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(1);
+    expect(onDOMNodeMouseOut.mock.calls[0][0]).toEqual(stub);
 
     node.simulate("mouseover");
     expect(onDOMNodeMouseOver.mock.calls).toHaveLength(1);
@@ -172,6 +173,7 @@ describe("GripMapEntry - complex", () => {
 
     node.simulate("mouseout");
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(2);
+    expect(onDOMNodeMouseOut.mock.calls[1][0]).toEqual(stub);
 
     node.simulate("mouseover");
     expect(onDOMNodeMouseOver.mock.calls).toHaveLength(2);

devtools/client/debugger/packages/devtools-reps/src/reps/tests/grip-map.js

@@ -236,6 +236,9 @@ describe("GripMap - Node-keyed entries", () => {
     node.at(2).simulate("mouseout");
 
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(3);
+    expect(onDOMNodeMouseOut.mock.calls[0][0]).toBe(grips[0]);
+    expect(onDOMNodeMouseOut.mock.calls[1][0]).toBe(grips[1]);
+    expect(onDOMNodeMouseOut.mock.calls[2][0]).toBe(grips[2]);
   });
 
   it("calls the expected function on click", () => {
@@ -292,6 +295,9 @@ describe("GripMap - Node-valued entries", () => {
     node.at(2).simulate("mouseout");
 
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(3);
+    expect(onDOMNodeMouseOut.mock.calls[0][0]).toBe(grips[0]);
+    expect(onDOMNodeMouseOut.mock.calls[1][0]).toBe(grips[1]);
+    expect(onDOMNodeMouseOut.mock.calls[2][0]).toBe(grips[2]);
   });
 
   it("calls the expected function on click", () => {

devtools/client/debugger/packages/devtools-reps/src/reps/tests/grip.js

@@ -380,6 +380,8 @@ describe("Grip - Object with connected nodes", () => {
     node.at(1).simulate("mouseout");
 
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(2);
+    expect(onDOMNodeMouseOut.mock.calls[0][0]).toBe(grips[0]);
+    expect(onDOMNodeMouseOut.mock.calls[1][0]).toBe(grips[1]);
   });
 
   it("calls the expected function on click", () => {

devtools/client/debugger/packages/devtools-reps/src/reps/tests/promise.js

@@ -129,6 +129,7 @@ describe("Promise - fulfilled with node", () => {
     node.simulate("mouseout");
 
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(1);
+    expect(onDOMNodeMouseOut).toHaveBeenCalledWith(grips[0]);
   });
 
   it("no inspect icon when the node is not connected to the DOM tree", () => {

devtools/client/debugger/packages/devtools-reps/src/reps/tests/text-node.js

@@ -70,6 +70,7 @@ describe("TextNode", () => {
     wrapper.simulate("mouseout");
 
     expect(onDOMNodeMouseOut.mock.calls).toHaveLength(1);
+    expect(onDOMNodeMouseOut).toHaveBeenCalledWith(object);
   });
 
   it("displays a button when the node is connected", () => {

devtools/client/debugger/packages/devtools-reps/src/reps/text-node.js

@@ -49,7 +49,7 @@ function TextNode(props) {
 
     if (onDOMNodeMouseOut) {
       Object.assign(baseConfig, {
-        onMouseOut: onDOMNodeMouseOut,
+        onMouseOut: _ => onDOMNodeMouseOut(grip),
       });
     }
 

devtools/client/shared/components/reps/reps.js

@@ -6925,7 +6925,7 @@ function ElementNode(props) {
 
     if (onDOMNodeMouseOut) {
       Object.assign(baseConfig, {
-        onMouseOut: onDOMNodeMouseOut
+        onMouseOut: _ => onDOMNodeMouseOut(object)
       });
     }
 
@@ -7112,7 +7112,7 @@ function TextNode(props) {
 
     if (onDOMNodeMouseOut) {
       Object.assign(baseConfig, {
-        onMouseOut: onDOMNodeMouseOut
+        onMouseOut: _ => onDOMNodeMouseOut(grip)
       });
     }