Bug 1575974 - Report any non-zero exit code as a process failure in nsIProcess r=gsvelto

EXIT_FAILURE is 'implementation defined' but can be defined to be 1.
In our case, pingsender exits with EXIT_FAILURE but nsIProcess wasn't
reporting it as failure because it thought failures were always negative.

Differential Revision: https://phabricator.services.mozilla.com/D45038

--HG--
extra : moz-landing-system : lando

toolkit/components/crashes/CrashService.jsm

@@ -65,7 +65,7 @@ function runMinidumpAnalyzer(minidumpPath, allThreads) {
             break;
           case "process-failed":
             gRunningProcesses.delete(process);
-            reject();
+            resolve();
             break;
           default:
             reject(new Error("Unexpected topic received " + topic));

xpcom/threads/nsProcessCommon.cpp

@@ -312,7 +312,7 @@ void nsProcess::ProcessComplete() {
   }
 
   const char* topic;
-  if (mExitValue < 0) {
+  if (mExitValue != 0) {
     topic = "process-failed";
   } else {
     topic = "process-finished";